Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(developer): ldml: more improvement for key-not-found 🙀 #10236

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 13, 2023

  • add keys on each row and add rows, mapping to a new reserved "gap (reserved)" key.
  • add a mechanism for reserved keys, in case we have others

For #9451

  • TODO: fix basic.txt

@keymanapp-test-bot skip

- add keys on each row and add rows, mapping to a new reserved "gap (reserved)" key.
- add a mechanism for reserved keys, in case we have others…

For #9451
- typo fix
- clarify default behavior for missing keys

For: #9451
@srl295 srl295 added this to the A17S28 milestone Dec 13, 2023
@srl295 srl295 self-assigned this Dec 13, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 13, 2023

@srl295 srl295 requested a review from mcdurdin December 14, 2023 21:18
- add the new gap key
- start adding the additional vkeys

For #9451
- rest of keys.
- found that the reserved gap key was 1/10th width, but fixed

For #9451
@srl295 srl295 marked this pull request as ready for review December 16, 2023 00:07
@srl295
Copy link
Member Author

srl295 commented Dec 18, 2023

../common/web/types/build/src/kmx/string-list.d.ts(1,35): error TS2307: Cannot find module 'src/ldml-keyboard/pattern-parser.js' or its corresponding type declarations.
[18:14:07 ](https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/431218?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&showLog=431218_1351_1351&logView=flowAware)  ../common/web/types/build/src/osk/osk.d.ts(1,33): error TS2307: Cannot find module 'src/keyman-touch-layout/keyman-touch-layout-file.js' or its corresponding type declarations.

strange errs

@mcdurdin
Copy link
Member

mcdurdin commented Dec 18, 2023 via email

@srl295
Copy link
Member Author

srl295 commented Dec 18, 2023

Src/ is inserted by vscode but needs to be a ./ or ../ relative path

5 month old commit… it's failing in master, opened PR #10279

@jahorton
Copy link
Contributor

Web build-check failure will likely be resolved by #10279.

@srl295
Copy link
Member Author

srl295 commented Dec 20, 2023

download failure would be mitigated by #9534

@srl295 srl295 merged commit 7d9eca1 into master Dec 20, 2023
17 checks passed
@srl295 srl295 deleted the feat/developer/9451-key-not-found-epic-ldml branch December 20, 2023 23:44
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.235-alpha

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-facto lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants