chore(windows): removed cached context windows engine #10065

rc-swag · 2023-11-23T07:01:08Z

User Testing

I have taken the context and store test for the acceptance tests on the wiki. We don't need the stores will just use the
043 - output and keystroke.kmx and 045 - deadkey and context.kmx
Use the text editor available on this PR in the User Testing section

GROUP_TEXT_EDITOR
GROUP_WORD_PAD (TSF)

Test cases

click to expand

The key referred to as "enter" is alternatively labelled "return" on some keyboards.

Keyboards for the following test are found in the zip file store_context_kbd.zip

TEST_OUTPUT_KEYSTROKE

Install 043 - output and keystroke.kmx
Open Text Editor
Select 043 - output and keystroke.kmx as the current keyboard.
Type 123

Expected Result: "abd3"

TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT

If not installed from the previous test - Install 043 - output and keystroke.kmx
Open Text Editor
Select 043 - output and keystroke.kmx as the current keyboard.
Type 12Enter3

Expected Result:
"abc
3"

TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY

If not installed from the previous test - Install 043 - output and keystroke.kmx
Open Text Editor
Select 043 - output and keystroke.kmx as the current keyboard.
Type 12left arrow keyright arrow key3

Expected Result WordPad: "abd3"

Expected Result TextEditor: "abc3"

TEST_DEADKEY_AND_CONTEXT

Install 045 - deadkey and context.kmx
Open Text Editor
Select 045 - deadkey and context.kmx as the current keyboard.
Type yzShift+/

Expected Result: "correct"

TEST_DEAD_CONTEXT_FRAME_KEY

Install 045 - deadkey and context.kmx
Open Text Editor
Select 045 - deadkey and context.kmx as the current keyboard.
Type yz left arrow keyright arrow keyShift+/

Expected Result: "<ab>?"

Removed the cached context from the windows engine

keymanapp-test-bot · 2023-11-23T07:01:13Z

User Test Results

Test specification and instructions

✅ GROUP_TEXT_EDITOR:
5 tests PASSED
- ✅ TEST_OUTPUT_KEYSTROKE (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Unzipped then installed the store_context keyboards using Keyman Configuration dialog. 2. Installed Text Editor 64 (EC Test App) from the PR build then Opened it. 3. Selected 043 - output and keystroke.kmx as the current keyboard. 4. Typed "123". Verified that "abd3" appeared on the Text Editor.
- ✅ TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 043 - output and keystroke.kmx as the current keyboard. 3. Typed "12". Pressed te key. Typed "3". Verified that (notes)
- ✅ TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY (PASSED): notes
- ✅ TEST_DEADKEY_AND_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz shift+/". Verified that the text "correct" appear as the output.
- ✅ TEST_DEAD_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz lef arrow key right arrow key shift+/". Verified that "?" text appear as the output. (notes)
✅ GROUP_WORD_PAD: (TSF)
5 tests PASSED
- ✅ TEST_OUTPUT_KEYSTROKE (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Unzipped then installed the store_context keyboards using Keyman Configuration dialog. 2. Opened WordPad. 3. Selected 043 - output and keystroke.kmx as the current keyboard. 4. Typed "123". Verified that "abd3" appeared on the Text Editor.
- ✅ TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 043 - output and keystroke.kmx as the current keyboard. 3. Typed "12". Pressed te key. Typed "3". Verified that (notes)
- ✅ TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (Keyman 17.0.220-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Installed the 043 - output and keystroke.kmx keyboard. 2. Opened the WordPad app. 3. Followed the steps mentioned in the instructions and show the expected result. (notes)
- ✅ TEST_DEADKEY_AND_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz shift+/". Verified that the text "correct" appears as the output.
- ✅ TEST_DEAD_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz lef arrow key right arrow key shift+/". Verified that "?" text appears as the output. (notes)

Test Artifacts

mcdurdin

LGTM

mcdurdin · 2023-11-23T20:58:00Z

windows/src/desktop/kmshell/kmshell.res

Please remove this file from the PR -- Its changes are result of the build and not relevant 😁

windows/src/engine/keyman32/appint/aiTIP.h

windows/src/engine/keyman32/appint/aiWin2000Unicode.cpp

windows/src/engine/keyman32/kmprocess.cpp

Co-authored-by: Marc Durdin <[email protected]>

bharanidharanj · 2023-11-28T08:23:17Z

Test Results

GROUP_TEXT_EDITOR:

TEST_OUTPUT_KEYSTROKE (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Unzipped then installed the store_context keyboards using Keyman Configuration dialog. 2. Installed Text Editor 64 (EC Test App) from the PR build then Opened it. 3. Selected 043 - output and keystroke.kmx as the current keyboard. 4. Typed "123". Verified that "abd3" appeared on the Text Editor.
TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 043 - output and keystroke.kmx as the current keyboard. 3. Typed "12". Pressed te key. Typed "3". Verified that
"abc
3" appeared on the Text Editor.
TEST_DEADKEY_AND_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz shift+/". Verified that the text "correct" appear as the output.
TEST_DEAD_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened the Text Editor (64 bit). 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz lef arrow key right arrow key shift+/". Verified that "?" text appear as the output.

..Text Editor Output

bharanidharanj · 2023-11-28T08:36:17Z

Test Results

GROUP_WORD_PAD: (TSF)

TEST_OUTPUT_KEYSTROKE (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Unzipped then installed the store_context keyboards using Keyman Configuration dialog. 2. Opened WordPad. 3. Selected 043 - output and keystroke.kmx as the current keyboard. 4. Typed "123". Verified that "abd3" appeared on the Text Editor.
TEST_OUTPUT_KEYSTROKE_INVALID_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 043 - output and keystroke.kmx as the current keyboard. 3. Typed "12". Pressed te key. Typed "3". Verified that
"abc
3" appeared on the Text Editor.
TEST_DEADKEY_AND_CONTEXT (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz shift+/". Verified that the text "correct" appears as the output.
TEST_DEAD_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (keyman 17.0.216-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Opened WordPad. 2. Selected 045 - deadkey and context.kms as the current keyboard. 3. Typed "yz lef arrow key right arrow key shift+/". Verified that "?" text appears as the output.

..in WordPad Editor

bharanidharanj · 2023-11-28T08:40:31Z

FYI, I got an error message during install the attached PR build (Keyman 17.0.216-alpha-test-10065) on Windows 10 OS. When I press the "Retry" button multiple times, the installation process proceeds further. Just want to bring it to your attention.

..error message during Keyman installation

mcdurdin · 2023-11-28T21:33:28Z

FYI, I got an error message during install the attached PR build (Keyman 17.0.216-alpha-test-10065) on Windows 10 OS. When I press the "Retry" button multiple times, the installation process proceeds further. Just want to bring it to your attention.

This is the same issue as you saw earlier -- issues with the keyman.com servers being slow. I am investigating.

rc-swag · 2023-11-29T00:08:35Z

@bharanidharanj I made a typo leaving out the '_' in TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY which means it didn't get converted into a checkbox test. I decided to quickly test it myself and it fails! I will have to dig into this later today.

rc-swag · 2023-11-29T00:10:25Z

Test Results

GROUP_TEXT_EDITOR:

TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY (PASS): notes

GROUP_WORD_PAD: (TSF)

TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY (FAILED): The result is abc3 which suggests getting the context from TSF apps and setting it in the core is failing.

…_if_needed

…-cached-context

rc-swag · 2023-11-30T11:36:55Z

@keymanapp-test-bot retest GROUP_WORD_PAD TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY
@bharanidharanj The failed test is ready for re-test you will need to download the keyman for windows build on this PR again.

bharanidharanj · 2023-11-30T14:31:57Z

Test Results

GROUP_WORD_PAD: (TSF)

TEST_OUTPUT_KEYSTROKE_CONTEXT_FRAME_KEY (PASSED): Tested with the attached PR build (Keyman 17.0.220-alpha-test-10065) on Windows 10 OS and here is my observation: 1. Installed the 043 - output and keystroke.kmx keyboard. 2. Opened the WordPad app. 3. Followed the steps mentioned in the instructions and show the expected result.

..in WordPad

keyman-server · 2023-12-01T18:03:21Z

Changes in this pull request will be available for download in Keyman version 17.0.221-alpha

chore(windows): removed cached context windows engine

4480a05

Removed the cached context from the windows engine

keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Nov 23, 2023

keymanapp-test-bot bot added this to the A17S26 milestone Nov 23, 2023

github-actions bot added windows/ core/ Keyman Core windows/config/ windows/engine/ chore labels Nov 23, 2023

chore(windows): add comments ReadContext

2dbad87

rc-swag marked this pull request as ready for review November 23, 2023 12:03

rc-swag requested review from ermshiperete and mcdurdin as code owners November 23, 2023 12:03

mcdurdin approved these changes Nov 23, 2023

View reviewed changes

rc-swag and others added 2 commits November 24, 2023 07:48

chore(windows): review comments

08b3764

Co-authored-by: Marc Durdin <[email protected]>

chore(windows): remove res from PR change resetcontext

23da871

github-actions bot added windows/config/ and removed windows/config/ labels Nov 23, 2023

rc-swag mentioned this pull request Nov 23, 2023

chore(windows): update windows engine unit tests to match removal of engine cached context #10071

Closed

mcdurdin approved these changes Nov 23, 2023

View reviewed changes

darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Nov 28, 2023

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 28, 2023

keymanapp-test-bot bot added the user-test-required User tests have not been completed label Nov 28, 2023

keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Nov 29, 2023

chore(windows): fix argument passed into to km_core_state_context_set…

63e4371

…_if_needed

github-actions bot added windows/config/ and removed windows/config/ labels Nov 30, 2023

chore(windows): Merge branch 'master' into chore/windows/10052/remove…

3506407

…-cached-context

github-actions bot added windows/config/ and removed windows/config/ labels Nov 30, 2023

chore(windows): Merge branch 'master' into chore/windows/10052/remove…

51a462c

…-cached-context

github-actions bot added windows/config/ and removed windows/config/ labels Nov 30, 2023

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Nov 30, 2023

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 30, 2023

rc-swag merged commit 864f378 into master Nov 30, 2023
17 checks passed

rc-swag deleted the chore/windows/10052/remove-cached-context branch November 30, 2023 22:33

mcdurdin mentioned this pull request Dec 8, 2023

refactor(core): KM_CORE_IT_INVALIDATE_CONTEXT shouldn't be no-op, or there should be other api to handle it #10182

Closed

8 tasks

ermshiperete mentioned this pull request Dec 15, 2023

refactor(linux): ibus: use km_core_state_context_set_if_needed #10212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(windows): removed cached context windows engine #10065

chore(windows): removed cached context windows engine #10065

rc-swag commented Nov 23, 2023 •

edited

Loading

keymanapp-test-bot bot commented Nov 23, 2023 •

edited

Loading

mcdurdin left a comment

mcdurdin Nov 23, 2023

bharanidharanj commented Nov 28, 2023

bharanidharanj commented Nov 28, 2023

bharanidharanj commented Nov 28, 2023

mcdurdin commented Nov 28, 2023

rc-swag commented Nov 29, 2023

rc-swag commented Nov 29, 2023 •

edited

Loading

rc-swag commented Nov 30, 2023 •

edited

Loading

bharanidharanj commented Nov 30, 2023

keyman-server commented Dec 1, 2023

chore(windows): removed cached context windows engine #10065

chore(windows): removed cached context windows engine #10065

Conversation

rc-swag commented Nov 23, 2023 • edited Loading

User Testing

Test cases

keymanapp-test-bot bot commented Nov 23, 2023 • edited Loading

User Test Results

Test Artifacts

mcdurdin left a comment

Choose a reason for hiding this comment

mcdurdin Nov 23, 2023

Choose a reason for hiding this comment

bharanidharanj commented Nov 28, 2023

Test Results

GROUP_TEXT_EDITOR:

bharanidharanj commented Nov 28, 2023

Test Results

GROUP_WORD_PAD: (TSF)

bharanidharanj commented Nov 28, 2023

mcdurdin commented Nov 28, 2023

rc-swag commented Nov 29, 2023

rc-swag commented Nov 29, 2023 • edited Loading

Test Results

GROUP_TEXT_EDITOR:

GROUP_WORD_PAD: (TSF)

rc-swag commented Nov 30, 2023 • edited Loading

bharanidharanj commented Nov 30, 2023

Test Results

GROUP_WORD_PAD: (TSF)

keyman-server commented Dec 1, 2023

rc-swag commented Nov 23, 2023 •

edited

Loading

keymanapp-test-bot bot commented Nov 23, 2023 •

edited

Loading

rc-swag commented Nov 29, 2023 •

edited

Loading

rc-swag commented Nov 30, 2023 •

edited

Loading