Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(windows): update windows engine unit tests to match removal of engine cached context #10071

Closed
rc-swag opened this issue Nov 23, 2023 · 2 comments · Fixed by #10184
Closed

chore(windows): update windows engine unit tests to match removal of engine cached context #10071

rc-swag opened this issue Nov 23, 2023 · 2 comments · Fixed by #10184
Assignees
@rc-swag
Labels
chore windows/
Milestone
B17S1

Comments

@rc-swag
Copy link
Contributor

rc-swag commented Nov 23, 2023

Work from #10065 means some the unit tests in windows engine.sln are no longer valid and need to either be updated or removed
@mcdurdin
Copy link
Member

Should we be adding these tests to CI?

@mcdurdin mcdurdin added this to the A17S26 milestone Nov 23, 2023
@rc-swag
Copy link
Contributor Author

rc-swag commented Nov 24, 2023

Should we be adding these tests to CI?

Yes would be good, some of them will be removed now because the testing at the core level is sufficient for context manipulation.

@darcywong00 darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023
@rc-swag rc-swag mentioned this issue Dec 8, 2023
Merged
1 task
@mcdurdin mcdurdin modified the milestones: A17S27, A17S28 Dec 8, 2023
@mcdurdin mcdurdin modified the milestones: A17S28, A17S29, A17S30 Dec 31, 2023
@rc-swag rc-swag modified the milestones: A17S30, B17S3 Jan 9, 2024
@keymanapp-test-bot keymanapp-test-bot bot modified the milestones: B17S3, B17S1 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rc-swag rc-swag

Labels
chore windows/
Projects
None yet
Milestone
B17S1
3 participants
@mcdurdin @darcywong00 @rc-swag