[khmer_angkor] Add non-printing characters to spacebar #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
changed the title
|
How does this present on earlier versions of Keyman which don't support those chars? |
Looks like literally. This went into the staging-17.0 branch so it would roll out when 17.0 gets released.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2221 by adding 17.0 non-printing glyphs (see keymanapp/keyman#9846) to the khmer_angkor spacebar.
Default spacebar outputs ZWSP (text
*ZWSp*)shift-spacebar outputs U+0020 (text
*Sp*)Because the spacebar typically shows the keyboard name, only the longpress glyph is really visible
Note: first commit is just differences from Keyman Developer 17.0 beta.
Can jump to ll. 1441, 1447, and 1901.