Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[khmer_angkor] bug: Long press on the spacebar key shows blank subkey in Khmer Angkor Keyboard #2221

Closed
1 of 8 tasks
bharanidharanj opened this issue May 23, 2023 · 3 comments · Fixed by #2588
Closed
1 of 8 tasks
Assignees
Labels

Comments

@bharanidharanj
Copy link

Describe the bug

I noticed that an empty subkey appears over the spacebar key, after long pressing the spacebar key.

Reproduce the bug

  1. Install Keyman 17.0.110-alpha build.
  2. Open Keyman In-App.
  3. Download and Install Khmer Angkor Keyboard.
  4. Switch to Khmer Angkor keyboard.
  5. Long press the Spacebar key.

Here, I noticed that a blank subkey appears over the spacebar key. I did not see the same behavior when I use the default EuroLatin (SIL) keyboard.

I have attached the video file for reference.

blanksubkey.mp4

Note: Able to reproduce it in previous version of keyman 17.0.98-alpha build.

Expected behavior

Long press on the space bar key should not show any empty subkey on the keyboard.

Related issues

No response

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

17.0 alpha

Operating system

Android 5.0, 9.0, 12.0

Device

Redmi Note 8 Pro, API 31 emulator

Target application

No response

Browser

No response

Keyboard name

khmer_angkor

Keyboard version

1.3

Language name

Khmer

Additional context

No response

@mcdurdin
Copy link
Member

This is a design issue with the Khmer Angkor keyboard -- longpress is supposed to give you a space whereas a short press on the spacebar inserts a zero-width space. However, as you point out, it isn't clear. Perhaps we should be labelling them?

Moving to keyboards repo.

@mcdurdin mcdurdin transferred this issue from keymanapp/keyman May 24, 2023
@mcdurdin mcdurdin changed the title bug(android): Long press on the spacebar key shows blank subkey in Khmer Angkor Keyboard [khmer_angkor] bug: Long press on the spacebar key shows blank subkey in Khmer Angkor Keyboard May 24, 2023
@MakaraSok MakaraSok self-assigned this Jun 2, 2023
@darcywong00
Copy link
Contributor

Just noting in 17.0, the OSK can also use key text:
*Sp* for regular space and
*ZWSp* for zero-width space

See
https://github.com/keymanapp/keyman/blob/7fa8ccac2a908281358869c61c216d5f3eeb7d7a/web/src/engine/osk/src/specialCharacters.ts#L46-L60

@LornaSIL
Copy link
Contributor

LornaSIL commented Mar 4, 2024

Fixed by #2588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants