Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency to setup.py, document installation instructions for Fedora #111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ What's New

Install
-------

Please run:

```
Expand All @@ -30,6 +31,33 @@ $ pip3 install gnomecast

If installing in a `mkvirtualenv` built virtual environment, make sure you include the `--system-site-packages` parameter to get the GTK bindings.

Fedora
~~~~~~

This section describes how to install this application on Fedora inside a virtual environment
without relying on ``python3-gobject`` system level package and ``--system-site-packages``
virtualenv flag.

1. Install OS level dependencies

```bash
sudo dnf install ffmpeg cairo-gobject-devel gobject-introspection-devel dbus-devel cairo-devel
```

2. Install Python dependencies

NOTE: ``dbus-python`` is an optional dependency.

```bash
pip3 install pygobject dbus-python
```

3. Install the application itself

```bash
pip3 install gnomecast
```

Run
---

Expand Down
4 changes: 3 additions & 1 deletion gnomecast.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@
line = "-"*70
ERROR_MESSAGE = """
{}
Python package "gi" (for building the GU not found.\n
Python package "gi" (for building the GUI not found.\n
If on Debian or Ubuntu, please run:
$ sudo apt-get install python3-gi\n
If on Fedora or RedHat, please run:
$ sudo dnf install python3-gobject
For other distributions please look up the equivalent package.\n
If this doesn't work, please report the error here:
https://github.com/keredson/gnomecast\n
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ pychromecast
bottle
pycaption
paste
pygobject
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def long_description():
'Programming Language :: Python',
'Programming Language :: Python :: 3',
],
install_requires=['pychromecast','bottle','pycaption','paste','html5lib'],
install_requires=['pychromecast','bottle','pycaption','paste','html5lib',
'pygobject'],
data_files=[
('share/icons/hicolor/16x16/apps', ['icons/gnomecast_16.png']),
('share/icons/hicolor/48x48/apps', ['icons/gnomecast_48.png']),
Expand Down