Add missing dependency to setup.py, document installation instructions for Fedora #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without does, the project doesn't install and work on Fedora 30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two changes:
setup.pyandrequirements.txtThis pull request adds missing
pygobjectdependency to the setup.py file. This dependency is needed to run the application.Right now the instructions rely on system level
python3-gipackage being installed which means it won't work in virtual environments without installingpygobjectPyPi package or relying on system site packages (which is not ideal and not the default behavior anymore).Keep in mind that this will still work even if
--system-site-packagesand OS level approach is used since that package will already be available in virtual environment.It adds installation instructions which documents which system level package dependencies are needed on Fedora.