Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.1.3 to permit release on CI #72

Merged
merged 16 commits into from
Dec 12, 2020
Merged

bump version to 0.1.3 to permit release on CI #72

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e4f5efb
bump version to 0.1.3 to permit release on CI
Nov 18, 2020
b8ec8fd
bump version to 0.1.3 to permit release on CI
Nov 18, 2020
0bfd48b
Update RELEASE_NOTES.md
Tianhao-Gu Nov 19, 2020
8d74391
added history to RELEASE_NOTES.md
Dec 1, 2020
f8111b1
Update RELEASE_NOTES.md
qzzhang Dec 1, 2020
f2d6a64
Update RELEASE_NOTES.md
jsfillman Dec 1, 2020
ea9b2e5
handle noclobber error for os.mkdir()
Dec 1, 2020
20a2260
Update RELEASE_NOTES.md
jsfillman Dec 1, 2020
1fd3435
Merge branch 'dcchivian-patch-1' into jsfillman-patch-1
Dec 1, 2020
85caefa
Merge pull request #74 from kbaseapps/jsfillman-patch-1
Dec 1, 2020
9fb2b7f
build local FTP server for tests
Tianhao-Gu Dec 2, 2020
b756685
remove unused argument
Tianhao-Gu Dec 2, 2020
e3e2797
Merge pull request #75 from Tianhao-Gu/fix_ftp_test
Tianhao-Gu Dec 2, 2020
e6376d1
Moved the change notes from under 1.1 to under 1.2
qzzhang Dec 9, 2020
4d039e4
Fix tests failing due to shock -> blobstore cutover
MrCreosote Dec 10, 2020
dd6a938
Remove .travis.yml
MrCreosote Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
#0.1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @jsfillman, @Tianhao-Gu and @qzzhang added code without release notes for 1.2 and 1.3 - can the 3 of you update the release notes please?

We should probably add a checklist or something, as I merged a PR without release notes myself. Should've caught that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 updated release note for 0.1.2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tianhao-Gu . I increased the version to v0.1.3 because there was a new commit with respect to the v0.1.2 that's released on CI (and it blocks re-release of the same version). That implies there was another change after the first v0.1.2. Anyone know what that change was? Maybe I can figure it out from the commit logs, but I figure you all might know rather than me resort to code forensics.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it wasn't too bad. The released commit on CI is df0bb65 which was from @qzzhang. Ever commit after than is from @jsfillman and appears to be his cleanup of our github framework. Not sure what that release note should be. @jsfillman what should we say is the change in RELEASE_NOTES.md for v0.1.3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qzzhang do you mind adding some release notes for #67 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrCreosote @Tianhao-Gu @jsfillman @qzzhang where are we at with this? are the only changes still to record in the release notes the github stuff from @jsfillman and the colon to underscore for SHOCK names?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrCreosote I went ahead and added what I could for the comments. I'd really like to merge this so I can register it on CI.KBASE.US and do integration testing of client modules against it. I'm sure @jsfillman would be better able to describe what changes he made between v0.1.2 and v0.1.3 (which I'm considering everything after commit df0bb65), but I made a much more general comment so we can get this through. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the release note for #67, then it created a new branch and pr #73.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added release notes as requested in #74.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged your RELEASE_NOTES changes. Working on errors in unit tests now.

- unrecorded changes

#0.1.2
- unrecorded changes

#0.1.1
- close no longer used sockets.

Expand Down
2 changes: 1 addition & 1 deletion kbase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ service-language:
python

module-version:
0.1.2
0.1.3

owners:
[rsutormin, msneddon, gaprice, scanon, tgu2]