bump version to 0.1.3 to permit release on CI #72

dcchivian · 2020-11-18T22:46:50Z

No description provided.

MrCreosote · 2020-11-18T22:55:30Z

RELEASE_NOTES.md

@@ -1,3 +1,9 @@
+#0.1.3


Looks like @jsfillman, @Tianhao-Gu and @qzzhang added code without release notes for 1.2 and 1.3 - can the 3 of you update the release notes please?

We should probably add a checklist or something, as I merged a PR without release notes myself. Should've caught that.

👍 updated release note for 0.1.2.

Thanks @Tianhao-Gu . I increased the version to v0.1.3 because there was a new commit with respect to the v0.1.2 that's released on CI (and it blocks re-release of the same version). That implies there was another change after the first v0.1.2. Anyone know what that change was? Maybe I can figure it out from the commit logs, but I figure you all might know rather than me resort to code forensics.

actually, it wasn't too bad. The released commit on CI is df0bb65 which was from @qzzhang. Ever commit after than is from @jsfillman and appears to be his cleanup of our github framework. Not sure what that release note should be. @jsfillman what should we say is the change in RELEASE_NOTES.md for v0.1.3?

@qzzhang do you mind adding some release notes for #67 ?

@MrCreosote @Tianhao-Gu @jsfillman @qzzhang where are we at with this? are the only changes still to record in the release notes the github stuff from @jsfillman and the colon to underscore for SHOCK names?

@MrCreosote I went ahead and added what I could for the comments. I'd really like to merge this so I can register it on CI.KBASE.US and do integration testing of client modules against it. I'm sure @jsfillman would be better able to describe what changes he made between v0.1.2 and v0.1.3 (which I'm considering everything after commit df0bb65), but I made a much more general comment so we can get this through. What do you think?

I updated the release note for #67, then it created a new branch and pr #73.

Also added release notes as requested in #74.

merged your RELEASE_NOTES changes. Working on errors in unit tests now.

MrCreosote · 2020-12-01T00:24:05Z

Looks like tests are failing

jsfillman

Let's see if we can find what stopped passing after commit d8091ef. 🤷

dcchivian · 2020-12-01T01:44:17Z

@jsfillman sounds good. Looks like the old log expired, but I suspect the current errors in the SDK unit tests are the same as the old commit. There appear to be 5 unit tests that are failing. https://github.com/kbaseapps/DataFileUtil/pull/72/checks?check_run_id=1477112011

dcchivian · 2020-12-01T01:46:49Z

4 errors/failures related to ftp tests (maybe the data on that path has been removed?) and one that appears to be a noclobber with a repeat path from another test

dcchivian · 2020-12-01T01:52:03Z

some of the tests are failing trying to do an ftp from ftp.uconn.edu. that address does not ping. not sure why that server was picked, but maybe we can test against a server from NCBI? Need to dig more to see whether the type of data matters...

Update RELEASE_NOTES with missing changes

dcchivian · 2020-12-01T02:37:06Z

some of the tests are failing trying to do an ftp from ftp.uconn.edu. that address does not ping. not sure why that server was picked, but maybe we can test against a server from NCBI? Need to dig more to see whether the type of data matters...

looks some of the tests actually want to save the test file that is subsequently downloaded. not sure what server we can use for that. thoughts?

build local FTP server for tests

codecov · 2020-12-02T02:18:38Z

Codecov Report

Merging #72 (dd6a938) into master (e36bf01) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   70.30%   70.21%   -0.09%     
==========================================
  Files           3        3              
  Lines        1155     1155              
==========================================
- Hits          812      811       -1     
- Misses        343      344       +1

Impacted Files	Coverage Δ
lib/DataFileUtil/DataFileUtilImpl.py	`91.23% <0.00%> (-0.15%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36bf01...dd6a938. Read the comment docs.

jsfillman

some of the tests are failing trying to do an ftp from ftp.uconn.edu. that address does not ping. not sure why that server was picked, but maybe we can test against a server from NCBI? Need to dig more to see whether the type of data matters...

looks some of the tests actually want to save the test file that is subsequently downloaded. not sure what server we can use for that. thoughts?

@Tianhao-Gu's fix seemed to do the trick!

dcchivian · 2020-12-03T01:22:00Z

unit tests are passing. travis-ci is failing on "make sdkbase". is the travis base image not using a pre-built kbase image? @MrCreosote @jsfillman @Tianhao-Gu @qzzhang how should we proceed? My feeling is the travis-ci is an issue that should be fixed, but seems beyond the scope of this PR for DataFileUtil. If you agree, then @MrCreosote should probably merge. Gavin, do you agree?

(also, the RELEASE_NOTES.md has been updated, which Gavin identified as needing to happen)

MrCreosote · 2020-12-04T00:25:20Z

I think we wanted to merge this PR to get the release notes correct before the 0.1.3 bump: #73

@qzzhang There's an open question for you - can you take a look?

IMO we should have the tests passing before we merge. It looks like they did pass at least once since we got code coverage, so it should be doable.

MrCreosote · 2020-12-04T00:26:45Z

From https://github.com/kbaseapps/DataFileUtil/commits/master, it looks like the tests broke here: c3a61c9

dcchivian · 2020-12-04T00:43:53Z

I think we wanted to merge this PR to get the release notes correct before the 0.1.3 bump: #73

@qzzhang There's an open question for you - can you take a look?

I think @Tianhao-Gu included the RELEASE_NOTES.md that @qzzhang put into #73, so merging #73 would be redundant. However, she should confirm that note on the : to _ filename change belongs with 0.1.1

dcchivian · 2020-12-04T00:49:09Z

From https://github.com/kbaseapps/DataFileUtil/commits/master, it looks like the tests broke here: c3a61c9

looking at the tests from that commit, it's not travis-ci that was broken back then rather the SDK unit tests that are passing now. however, we still need to fix the current travis-ci issue with "make sdkbase". I have no idea why it's building from scratch. is it always supposed to do that? @jsfillman @MrCreosote do you happen to know?

MrCreosote · 2020-12-04T01:06:36Z

@jsfillman Do we even need travis anymore or is it all covered by GHA?

- blobstore fails earlier with a more relevant error message when presented with an invalid uuid - blobstore will not accept node data without a file Note that while making these changes, 4 google drive tests started failing for unknown reasons. It seems extremly unlikely that the changes here caused that.

dcchivian · 2020-12-11T23:16:03Z

@MrCreosote @jsfillman @Tianhao-Gu @qzzhang so the remaining error is in travis-ci and seems to be connected to blobstore. Is that a blocker to merging? Guessing yes since Gavin appears to be actively working on it, but please confirm.

MrCreosote · 2020-12-11T23:37:15Z

The last build that completed showed the make sdkbase error: https://travis-ci.org/github/kbaseapps/DataFileUtil/builds/748460971

Switching to Github Actions. GHA does everything the travis.yml file does, but also runs tests.

MrCreosote · 2020-12-12T00:21:41Z

couple of follow on issues for this PR:
#80
#79

Dylan Chivian added 2 commits November 18, 2020 14:44

bump version to 0.1.3 to permit release on CI

e4f5efb

bump version to 0.1.3 to permit release on CI

b8ec8fd

dcchivian requested review from jsfillman, MrCreosote, qzzhang and Tianhao-Gu as code owners November 18, 2020 22:46

MrCreosote requested changes Nov 18, 2020

View reviewed changes

Tianhao-Gu and others added 2 commits November 19, 2020 12:21

Update RELEASE_NOTES.md

0bfd48b

added history to RELEASE_NOTES.md

8d74391

jsfillman approved these changes Dec 1, 2020

View reviewed changes

jsfillman requested changes Dec 1, 2020

View reviewed changes

qzzhang and others added 2 commits November 30, 2020 20:01

Update RELEASE_NOTES.md

f8111b1

Update RELEASE_NOTES.md

f2d6a64

jsfillman mentioned this pull request Dec 1, 2020

Update RELEASE_NOTES with missing changes #74

Merged

Dylan Chivian and others added 4 commits November 30, 2020 18:16

handle noclobber error for os.mkdir()

ea9b2e5

Update RELEASE_NOTES.md

20a2260

Merge branch 'dcchivian-patch-1' into jsfillman-patch-1

1fd3435

Merge pull request #74 from kbaseapps/jsfillman-patch-1

85caefa

Update RELEASE_NOTES with missing changes

Tianhao-Gu and others added 3 commits December 1, 2020 19:38

build local FTP server for tests

9fb2b7f

remove unused argument

b756685

Merge pull request #75 from Tianhao-Gu/fix_ftp_test

e3e2797

build local FTP server for tests

jsfillman approved these changes Dec 2, 2020

View reviewed changes

qzzhang and others added 2 commits December 8, 2020 19:40

Moved the change notes from under 1.1 to under 1.2

e6376d1

Remove .travis.yml

dd6a938

Switching to Github Actions. GHA does everything the travis.yml file does, but also runs tests.

MrCreosote approved these changes Dec 12, 2020

View reviewed changes

MrCreosote merged commit 99129b3 into master Dec 12, 2020

MrCreosote deleted the dcchivian-patch-1 branch December 12, 2020 00:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump version to 0.1.3 to permit release on CI #72

bump version to 0.1.3 to permit release on CI #72

dcchivian commented Nov 18, 2020

MrCreosote Nov 18, 2020

Tianhao-Gu Nov 19, 2020

dcchivian Nov 19, 2020

dcchivian Nov 20, 2020

Tianhao-Gu Nov 20, 2020

dcchivian Nov 26, 2020

dcchivian Dec 1, 2020

qzzhang Dec 1, 2020

jsfillman Dec 1, 2020

dcchivian Dec 1, 2020

MrCreosote commented Dec 1, 2020

jsfillman left a comment

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

codecov bot commented Dec 2, 2020 •

edited

Loading

jsfillman left a comment

dcchivian commented Dec 3, 2020 •

edited

Loading

MrCreosote commented Dec 4, 2020

MrCreosote commented Dec 4, 2020

dcchivian commented Dec 4, 2020

dcchivian commented Dec 4, 2020

MrCreosote commented Dec 4, 2020

dcchivian commented Dec 11, 2020 •

edited

Loading

MrCreosote commented Dec 11, 2020

MrCreosote commented Dec 12, 2020

bump version to 0.1.3 to permit release on CI #72

bump version to 0.1.3 to permit release on CI #72

Conversation

dcchivian commented Nov 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrCreosote commented Dec 1, 2020

jsfillman left a comment

Choose a reason for hiding this comment

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

dcchivian commented Dec 1, 2020

codecov bot commented Dec 2, 2020 • edited Loading

Codecov Report

jsfillman left a comment

Choose a reason for hiding this comment

dcchivian commented Dec 3, 2020 • edited Loading

MrCreosote commented Dec 4, 2020

MrCreosote commented Dec 4, 2020

dcchivian commented Dec 4, 2020

dcchivian commented Dec 4, 2020

MrCreosote commented Dec 4, 2020

dcchivian commented Dec 11, 2020 • edited Loading

MrCreosote commented Dec 11, 2020

MrCreosote commented Dec 12, 2020

codecov bot commented Dec 2, 2020 •

edited

Loading

dcchivian commented Dec 3, 2020 •

edited

Loading

dcchivian commented Dec 11, 2020 •

edited

Loading