WidgetId → Id, revise handling of Action and pending ops #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e send_action -> action and require id parameter
There is no reason to localise this operation
Also remove EditBox: Scrollable (the box uses an internal scroll bar)
This is the only Event variant it makes sense to support
Possibly this was required for handling of shortcuts with nav focus without key focus? In any case, key focus is automatically requested on nav focus now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
WidgetId→Id(finally!). As noted in kas-gui/design#10 , variations were considered and rejected, so this is mostly just a rename.Revise pending ops in
EventState. Instead of attempting to maintain order of the various ops, they are considered independently in the most appropriate order.Remove
*cx |= actionoperator; replaceEventState::send_action(action)method withEventState::action(id, action)method whereid: impl HasId(a new trait supporting bothIdand widgets). This allows actions to be applied only to sub-trees.Action::RECONFIGUREandUPDATEnow apply to sub-trees.SET_RECTandRESIZEcould be given the same treatment (the latter probably requires significant adjustment toLayout::size_rulesgiving itsSizeCxcontrol over recursion to children). Our current renderer does not support "damage regions" (esp. with regards to transparency and draw order), but if another renderer needed this we would probably want to track aredraw: Option<Id>field inEventState(and would need similar tracking for animations).Aside: sub-tree operations feel unnecessary considering resizes are 1-2ms and redraws 1-2ms (debug builds). But maybe more constrained systems will benefit. Further aside: a future WGPU version is required to fix resizing: wgpu#4227 appears to fix this for me. Edit: correct render time by omitting frame presentation (wait) time.