Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WidgetId design doc #10

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add WidgetId design doc #10

merged 2 commits into from
Oct 9, 2023

Conversation

dhardy
Copy link
Contributor

@dhardy dhardy commented Oct 7, 2023 •
edited
Loading

Rendered: LINK

Scope: widget identifiers (paths)

Status: implemented; some alternatives and tweaks considered

@dhardy
Copy link
Contributor Author

dhardy commented Oct 9, 2023

Done: rename WidgetId → Id: kas-gui/kas#413

Investigated: using split OwnedId / Id (incomplete: no GC strategy for lookup table). It's possible, but likely makes user code more complex due to having two identity types and requiring explicit conversion between them.

Investigated: replaces uses of &Id with Id in theme/draw.rs. Result: negligible (hard to measure) perf. impact; too many instances of .clone().

@dhardy dhardy merged commit 4b493a1 into master Oct 9, 2023
@dhardy dhardy mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy