Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5976: Only genrate ETCD PKI for local ETCD setup #6008

Conversation

jabellard
Copy link
Contributor

@jabellard jabellard commented Jan 1, 2025

Cherry pick of #5976 on release-1.12.
#5976: Only genrate ETCD PKI for local ETCD setup
For details on the cherry pick process, see the cherry pick requests page.

`karmada-operator`: Fixed the issue that external ETCD certificate be overwritten by generated in-cluster ETCD certificate.

@karmada-bot karmada-bot requested review from lonelyCZ and Poor12 January 1, 2025 20:24
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 1, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes missing coverage. Please review.

Project coverage is 46.50%. Comparing base (3e154f7) to head (2032eb7).

Files with missing lines Patch % Lines
operator/pkg/tasks/init/upload.go 0.00% 19 Missing ⚠️
operator/pkg/certs/certs.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #6008      +/-   ##
================================================
- Coverage         46.51%   46.50%   -0.02%     
================================================
  Files               664      664              
  Lines             54785    54789       +4     
================================================
- Hits              25485    25481       -4     
- Misses            27673    27680       +7     
- Partials           1627     1628       +1     
Flag Coverage Δ
unittests 46.50% <19.35%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@karmada-bot karmada-bot merged commit 0e82ce1 into karmada-io:release-1.12 Jan 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants