-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ETCD PKI Provisioning Issue in Karmada Operator #5976
Fix ETCD PKI Provisioning Issue in Karmada Operator #5976
Conversation
Signed-off-by: Joe Nathan Abellard <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5976 +/- ##
==========================================
+ Coverage 48.23% 48.25% +0.01%
==========================================
Files 664 664
Lines 54749 54753 +4
==========================================
+ Hits 26410 26419 +9
+ Misses 26624 26621 -3
+ Partials 1715 1713 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks, overall LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@jabellard
I assume this has been tested on your side.
In addition, this should be backported to release-1.12 as well, please let me know if you'd like to do it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @RainbowMango . I just submitted this PR for that. |
…6-upstream-release-1.12 Automated cherry pick of #5976: Only genrate ETCD PKI for local ETCD setup
I see. Thank you. By the way, we will cut a new alpha release from the master and some patch releases from release branches this week as per the release cycle. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When provisioning a Karmada instance to be managed by the Karmada operator, there's support for both in-cluster and external ETCD modes. When external ETCD mode is used, the operator should skip setting up an in-cluster ETCD instance, which entails setting up PKI for the instance and deploying it as a stateful set. However, currently, in external ETCD mode, the operator will skip deploying the stateful set, but will still generate PKI, which is an issue. In external ETCD mode, all tasks relevant to setting up an in-cluster instance should be skipped.
Which issue(s) this PR fixes:
Fixes #5975
Special notes for your reviewer:
Does this PR introduce a user-facing change?: