Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ETCD PKI Provisioning Issue in Karmada Operator #5976

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

jabellard
Copy link
Contributor

@jabellard jabellard commented Dec 25, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:
When provisioning a Karmada instance to be managed by the Karmada operator, there's support for both in-cluster and external ETCD modes. When external ETCD mode is used, the operator should skip setting up an in-cluster ETCD instance, which entails setting up PKI for the instance and deploying it as a stateful set. However, currently, in external ETCD mode, the operator will skip deploying the stateful set, but will still generate PKI, which is an issue. In external ETCD mode, all tasks relevant to setting up an in-cluster instance should be skipped.

Which issue(s) this PR fixes:
Fixes #5975

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-operator`: Fixed the issue that external ETCD certificate be overwritten by generated in-cluster ETCD certificate.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 25, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 25, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes missing coverage. Please review.

Project coverage is 48.25%. Comparing base (c9ca6ac) to head (5a7f917).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/tasks/init/upload.go 0.00% 19 Missing ⚠️
operator/pkg/certs/certs.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5976      +/-   ##
==========================================
+ Coverage   48.23%   48.25%   +0.01%     
==========================================
  Files         664      664              
  Lines       54749    54753       +4     
==========================================
+ Hits        26410    26419       +9     
+ Misses      26624    26621       -3     
+ Partials     1715     1713       -2     
Flag Coverage Δ
unittests 48.25% <19.35%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

Thanks, overall LGTM.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jabellard
I assume this has been tested on your side.

In addition, this should be backported to release-1.12 as well, please let me know if you'd like to do it.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2024
@RainbowMango RainbowMango added this to the v1.13 milestone Dec 28, 2024
@karmada-bot karmada-bot merged commit 36051f6 into karmada-io:master Dec 28, 2024
21 checks passed
@jabellard
Copy link
Contributor Author

/lgtm /approve

@jabellard I assume this has been tested on your side.

In addition, this should be backported to release-1.12 as well, please let me know if you'd like to do it.

Hey @RainbowMango . I just submitted this PR for that.

karmada-bot added a commit that referenced this pull request Jan 2, 2025
…6-upstream-release-1.12

Automated cherry pick of #5976: Only genrate ETCD PKI for local ETCD setup
@RainbowMango
Copy link
Member

I see. Thank you.

By the way, we will cut a new alpha release from the master and some patch releases from release branches this week as per the release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ETCD PKI provisioning Issue in Karmada Operator
5 participants