Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build arguments in goreleaser yaml #2347

Merged
merged 4 commits into from
Sep 21, 2023
Merged

fix build arguments in goreleaser yaml #2347

merged 4 commits into from
Sep 21, 2023

Conversation

leuyentran
Copy link
Contributor

Change Overview

As discussed in #2343 (comment), the --build-arg in .goreleaser.yml are incorrect. This PR change them to correct variable.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@leuyentran leuyentran mentioned this pull request Sep 20, 2023
Closed
10 tasks
pavannd1
pavannd1 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Sep 21, 2023
@mergify mergify bot merged commit 0573300 into master Sep 21, 2023
14 checks passed
@mergify mergify bot deleted the fix-build-arg-in-goreleaser-yaml branch September 21, 2023 01:49
julio-lopez
julio-lopez reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1: LG 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio-lopez julio-lopez julio-lopez left review comments

@pavannd1 pavannd1 pavannd1 approved these changes

@ankitjain235 ankitjain235 Awaiting requested review from ankitjain235

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leuyentran @julio-lopez @pavannd1