Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kopia commit in kanister-tools image kastenhq 663cbad #2343

Closed
wants to merge 39 commits into from

Conversation

leuyentran
Copy link
Contributor

@leuyentran leuyentran commented Sep 19, 2023

Change Overview

This PR modifies kopia commit to kastenhq/kopia@663cbad in kanister-tools image after Kopia binary upgrade changes.

The commit used here is from forked repo https://github.com/kastenhq/kopia/tree/kopia-at-edfa9ee-minus-32193f7 that is relatively in-sync with upstream at the time of this PR. The same commit is used for go.mod file for kansiter which provides the benefit of synced-context.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

.goreleaser.yml Outdated
- "--build-arg=kopiaBuildCommit=3551f74"
- "--build-arg=kopiaRepoOrg=kopia"
# Refers to https://github.com/kastenhq/kopia/commit/663cbad414207f077c666637fabfb22b47855959
- "--build-arg=kopiaBuildCommit=663cbad"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavannd1 @ankitjain235 Are these --build-arg used in docker/tools/Dockerfile ? If so they need to change to kopia_build_commit and kopia_repo_org

Copy link
Contributor

@ankitjain235 ankitjain235 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are to be used in docker/tools/Dockerfile. This seems like a bug from the very beginning. Thanks a lot for noticing it.

Copy link
Contributor Author

@leuyentran leuyentran Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll raise a separate PR for fixing that #2347

@ankitjain235 ankitjain235 self-requested a review September 20, 2023 05:26
@leuyentran leuyentran changed the title Update kopia commit in kanister-tools image kastenhq 663cbad {WIP} Update kopia commit in kanister-tools image kastenhq 663cbad Sep 20, 2023
@kanisterio kanisterio deleted a comment from github-actions bot Sep 21, 2023
@leuyentran leuyentran changed the title {WIP} Update kopia commit in kanister-tools image kastenhq 663cbad Update kopia commit in kanister-tools image kastenhq 663cbad Sep 22, 2023
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dependabot bot and others added 18 commits October 18, 2023 15:11
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@3df4ab1...8ade135)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 39.1.2 to 39.2.0.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@4196030...8238a41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the common-golang group with 2 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) and [google.golang.org/api](https://github.com/googleapis/google-api-go-client).


Updates `github.com/aws/aws-sdk-go` from 1.45.13 to 1.45.16
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.13...v1.45.16)

Updates `google.golang.org/api` from 0.142.0 to 0.143.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.142.0...v0.143.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: common-golang
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: common-golang
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Prasad Ghangal <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Remove test files from kando package

Signed-off-by: Rajat Gupta <[email protected]>

* - Remove Unused Functions
- Refactored helper function

Signed-off-by: Rajat Gupta <[email protected]>

---------

Signed-off-by: Rajat Gupta <[email protected]>
Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.30.7 to 0.31.0.
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.30.7...v0.31.0)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Akanksha Kumari <[email protected]>
Co-authored-by: Pavan Navarathna <[email protected]>
…rogress (#2023)

* Add phase level progress fields in actionset object

Signed-off-by: Prasad Ghangal <[email protected]>

* Change weight based progress calc with func implementation

Signed-off-by: Prasad Ghangal <[email protected]>

* Refactor and add unit tests for phase progress

Signed-off-by: Prasad Ghangal <[email protected]>

* Update generated deepcopy methods

Signed-off-by: Prasad Ghangal <[email protected]>

* Fix import cycle issue in test

Signed-off-by: Prasad Ghangal <[email protected]>

* Update pkg/apis/cr/v1alpha1/types.go

Co-authored-by: Pavan Navarathna <[email protected]>

* Update pkg/apis/cr/v1alpha1/types.go

Co-authored-by: Pavan Navarathna <[email protected]>

* Update pkg/apis/cr/v1alpha1/types.go

Co-authored-by: Pavan Navarathna <[email protected]>

* Update pkg/apis/cr/v1alpha1/types.go

Co-authored-by: Pavan Navarathna <[email protected]>

* Use correct action index while updating action phase state

Signed-off-by: Prasad Ghangal <[email protected]>

* Implement ExecutionProgress method on Kanister functions (#2117)

* Implement ExecutionProgress method on Kanister functions

Signed-off-by: Prasad Ghangal <[email protected]>

* Set LastTransitionTime in ExecutionProgress return

Signed-off-by: Prasad Ghangal <[email protected]>

* Update pkg/function/backup_data.go

Co-authored-by: Pavan Navarathna <[email protected]>

---------

Signed-off-by: Prasad Ghangal <[email protected]>
Co-authored-by: Pavan Navarathna <[email protected]>

* Implement ExecProgress on test function

Signed-off-by: Prasad Ghangal <[email protected]>

* Remove unused mockPhase in test

Signed-off-by: Prasad Ghangal <[email protected]>

* Remove unnecessary whitespace in updateActionProgress func

Signed-off-by: Prasad Ghangal <[email protected]>

---------

Signed-off-by: Prasad Ghangal <[email protected]>
Signed-off-by: Prasad Ghangal <[email protected]>
Co-authored-by: Pavan Navarathna <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.26.3 to 0.26.9.
- [Commits](kubernetes/code-generator@v0.26.3...v0.26.9)

---
updated-dependencies:
- dependency-name: k8s.io/code-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7.0 (#2362)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.17.0/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the common-golang group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).

- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.16...v1.45.21)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: common-golang
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 39.2.0 to 39.2.1.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@8238a41...db153ba)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Revert "Temporarily disable Postgres tests (#2367)"

This reverts commit 06be966.

* Disable mysql app from integration test

Signed-off-by: Akanksha Kumari <[email protected]>

* Revert "Disable mysql app from integration test"

This reverts commit 7eb9ec4.

* Remove Maria DB

---------

Signed-off-by: Akanksha Kumari <[email protected]>
Co-authored-by: Akanksha Kumari <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
dependabot bot and others added 19 commits October 18, 2023 15:11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.8 to 2.21.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@6a28655...ddccb87)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Rename PodRunner's RunEx to Run

* Improve readability

Co-authored-by: Pavan Navarathna <[email protected]>

---------

Co-authored-by: Pavan Navarathna <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* error responding fixed for minio check

* Comment in build/test.sh updated

Co-authored-by: Vivek Singh <[email protected]>

---------

Co-authored-by: Vivek Singh <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* running of build & docs containers refactored

* A `run` rule fixed in Makefile

* build/run_container.sh + minor fixes in Makefile

Signed-off-by: Sergey Aksenov <[email protected]>

* trivial review fixes

Signed-off-by: Sergey Aksenov <[email protected]>

* review comments fixed

Signed-off-by: Sergey Aksenov <[email protected]>

---------

Signed-off-by: Sergey Aksenov <[email protected]>
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.26.3 to 0.26.9.
- [Commits](kubernetes/apimachinery@v0.26.3...v0.26.9)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](golang/net@v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@08b4669...483ef80)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavan Navarathna <[email protected]>
Bumps the common-golang group with 3 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [golang.org/x/oauth2](https://github.com/golang/oauth2) and [google.golang.org/api](https://github.com/googleapis/google-api-go-client).


Updates `github.com/aws/aws-sdk-go` from 1.45.21 to 1.45.25
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.21...v1.45.25)

Updates `golang.org/x/oauth2` from 0.12.0 to 0.13.0
- [Commits](golang/oauth2@v0.12.0...v0.13.0)

Updates `google.golang.org/api` from 0.143.0 to 0.147.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.143.0...v0.147.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: common-golang
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: common-golang
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: common-golang
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix for running tests locally

Signed-off-by: Sergey Aksenov <[email protected]>

* A `ERROR: Cannot connect to the Docker daemon at unix:///path_to_socket. Is the docker daemon running?` error fixed

Signed-off-by: Sergey Aksenov <[email protected]>

* fixed failing of some test after running `make test` within local environment

Signed-off-by: Sergey Aksenov <[email protected]>

* review comments fixed

Signed-off-by: Sergey Aksenov <[email protected]>

---------

Signed-off-by: Sergey Aksenov <[email protected]>
* Remove unused DescribeBackups function

* Remove related tests

* Remove related docs

* Use a different constant
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.3 to 0.26.9.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.26.3...v0.26.9)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updated go version

Signed-off-by: mabhi <[email protected]>

* Update kanister image version

Signed-off-by: mabhi <[email protected]>

* Update golangci linter version

Signed-off-by: mabhi <[email protected]>

* Removed deprecated go flag (-i)

Signed-off-by: mabhi <[email protected]>

---------

Signed-off-by: mabhi <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Support of read only mount added

Signed-off-by: Sergey Aksenov <[email protected]>

* review comments fixed

Signed-off-by: Sergey Aksenov <[email protected]>

* renamings regarding review comments

Signed-off-by: Sergey Aksenov <[email protected]>

---------

Signed-off-by: Sergey Aksenov <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@leuyentran leuyentran closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.