Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename subject_id to patient_id for meds #63

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Rename subject_id to patient_id for meds #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/aces/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
# query results
result = query.query(task_cfg, predicates_df)

if cfg.data.standard.lower() == "meds":
result = result.rename(columns={"subject_id": "patient_id"})

Check warning on line 49 in src/aces/__main__.py

View check run for this annotation

Codecov / codecov/patch

src/aces/__main__.py#L49 

Added line #L49 was not covered by tests
Comment on lines +48 to +49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column renaming logic is clearly implemented. However, this line is not covered by tests, which is crucial for ensuring that the renaming works correctly under all conditions.

+ # Suggestion to add tests covering this specific renaming logic

Committable suggestion was skipped due to low confidence.

Tools
GitHub Check: codecov/patch

[warning] 49-49: src/aces/main.py#L49
Added line #L49 was not covered by tests


# save results to parquet
os.makedirs(os.path.dirname(cfg.output_filepath), exist_ok=True)
result.write_parquet(cfg.output_filepath, use_pyarrow=True)
Expand Down
Loading