Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce from and to attributes on @EnumSource (#4185) #4221

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Introduce from and to attributes on @EnumSource (#4185) #4221

merged 5 commits into from
Jan 8, 2025

Conversation

yhkuo41
Copy link
Contributor

@yhkuo41 yhkuo41 commented Dec 24, 2024

Resolves #4185.

Overview

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@yhkuo41
Add validations for enum range selection
07806ad 
Ensure `from` and `to` are empty when the enum has no constants, and
validate `from` comes before `to` like `EnumSet.range`. Mark the `from`
and `to` attributes as EXPERIMENTAL.

Resolves junit-team#4185.
@yhkuo41 yhkuo41 requested a review from marcphilipp January 3, 2025 14:28
@marcphilipp marcphilipp merged commit cc2f60c into junit-team:main Jan 8, 2025
15 checks passed
@marcphilipp
Copy link
Member

@yhkuo41 Thank you for your contribution! 👍

@yhkuo41 yhkuo41 deleted the issues/4185-enum-source-range branch January 8, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesLgn CharlesLgn CharlesLgn left review comments

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support range filter in @EnumSource
3 participants
@yhkuo41 @marcphilipp @CharlesLgn