Introduce from and to attributes on @EnumSource (#4185) #4221
+175
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesLgn
reviewed
Dec 27, 2024
| @@ -63,6 +63,8 @@ | |||
| * first parameter of the {@code @ParameterizedTest} method is used. | |||
| * | |||
| * @see #names | |||
| * @see #from | |||
| * @see #to | |||
There was a problem hiding this comment.
maybe also add it to the mode() method javadoc
| @@ -164,6 +172,15 @@ void testWithEnumSourceRegex(ChronoUnit unit) { | |||
| } | |||
| // end::EnumSource_regex_example[] | |||
|
|
|||
| // tag::EnumSource_range_exclude_example[] | |||
| @ParameterizedTest | |||
| @EnumSource(mode = EXCLUDE, from = "HOURS", to = "DAYS", names = { "HALF_DAYS" }) | |||
There was a problem hiding this comment.
this test exemple will depend on the JDK. So, if the order is change, it can impact your test. is it not better to use a home made enum for the test exemple ?
| @EnumSource(from = "HOURS", to = "DAYS") | ||
| void testWithEnumSourceRange(ChronoUnit unit) { | ||
| assertTrue(EnumSet.of(ChronoUnit.HOURS, ChronoUnit.HALF_DAYS, ChronoUnit.DAYS).contains(unit)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| assertFalse(EnumSet.of(ChronoUnit.SECONDS).contains(unit)); | |
| } |
| } | ||
| E from = enumSource.from().isEmpty() ? constants[0] : Enum.valueOf(enumClass, enumSource.from()); | ||
| E to = enumSource.to().isEmpty() ? constants[constants.length - 1] : Enum.valueOf(enumClass, enumSource.to()); | ||
| return EnumSet.range(from, to); |
There was a problem hiding this comment.
What happen if from > to or if from == to ?
It maybe need to be specify somewhere in the doc, and have a test on this cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4185.
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations