-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Manopt to list of solvers #3568
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3568 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 37 37
Lines 5624 5629 +5
=======================================
+ Hits 5533 5538 +5
Misses 91 91 ☔ View full report in Codecov by Sentry. |
How does documenter check for the Readme and why is that needed? Currently it looks for
but we left the 80s and the rule to capitalise everything and have
|
Co-authored-by: Ronny Bergmann <[email protected]>
Co-authored-by: Ronny Bergmann <[email protected]>
Preview: https://jump.dev/JuMP.jl/previews/PR3568/packages/Manopt/ I should just find a way to turn vale errors into warnings for external packages. |
The preview looks nice! Yes, I do not understand which warnings and errors you have there – the first error says, Exclamation marks are not allowed? That is a super strict rule! (Oh! an error ;)) |
We run https://vale.sh with the Google style guide https://github.com/errata-ai/Google. The typos can be fixed by adding them to the allow-list: https://github.com/jump-dev/JuMP.jl/blob/master/docs/styles/Vocab/JuMP-Vocab/accept.txt For the exclaimation rule, see https://developers.google.com/style/periods#exclamation-points |
Quite interesting, will keep that in mind – until now we only run code style tests, but this looks nice as well. |
Opened a few changes here: JuliaManifolds/Manopt.jl#315 |
cc @kellertuer @mateuszbaran
Basic
MOI.Test.runtests
. Some test excludes arepermissible, but the reason for skipping a particular test should be
documented.
use the solver with JuMP: https://manoptjl.org/stable/extensions.html#JuMP.jl
Documentation
docs/src/installation.md
Optional
docs/packages.toml