Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to Readme.md #315

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Minor changes to Readme.md #315

merged 2 commits into from
Nov 15, 2023

Conversation

odow
Copy link
Contributor

@odow odow commented Nov 8, 2023

Readme.md Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #315 (2969182) into master (ed8fcef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          79       79           
  Lines        7353     7353           
=======================================
  Hits         7334     7334           
  Misses         19       19           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kellertuer
Copy link
Member

You can ignore the changelog error failing here, that is just if we release a new version with a PR the changelog should have an entry. I will add this to another version anyways. You can still add a small (unreleased) entry with a change of the readme as a comment if you want.

@kellertuer
Copy link
Member

A : works as well, sure – do you need this registered or is it enough to have this on master/main?

@odow
Copy link
Contributor Author

odow commented Nov 15, 2023

It's enough to just have this on main. I can use a commit hash as the reference.

@kellertuer
Copy link
Member

Great. Then we can merge this already and it will be part of the next (but a bit later) release.

@kellertuer kellertuer merged commit c1fc4a5 into JuliaManifolds:master Nov 15, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants