Feature/f 165 linechart barchart support #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reflect predcition styling
…-functionalities-for-forecast
…ineChart component
…g and svg download
…ll later be used by the CategoricalChart and ContinuousChart copmpeontn
…ater support categorical and continues data
…be-available-on-minimized
…ghcharts options - fixes the chart export color problem
…categorical chart options for highchart
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F-165
I have introduced a new component called
CategoricalChartand refactored all chart components to reduce code redundancy. In particular, I have introduced theChartContainerto prevent redundant code...This is now the first working version I’d like to submit for the PR. There are still a few minor things missing, but to ensure the
CategoricalChartcomponent can be used in the main branch as soon as possible, it makes sense to merge this version now.All the other minor todos have already been added to F-183.