Feature/f 142 comparison portal

[bohdangarchu]

Comparison Portal

Features

• country selection query parameters
• error handling using snackbar
• error handling for individual charts
• fixed linechart - didn't react on input data change
• hooks for multiple queries
• fixed some type definitions

To-Do

• button to reset selection
• initially remove disabled countries from selection
• disable country after error
• transparent charts
• increase chart height - will be done in f-183

Issues

• need to integrate Feature/f 165 linechart barchart support #134
• handling of absent data for individual graphs
• page jumps to top when clicking select - known nextui issue [BUG] - Select scrolls page and immediately closes popover on click nextui-org/nextui#3571
• LineChart modal minimize button makes the page unclickable - general issue with linechart modal, added f-182 for further investigation

[netlify]

✅ Deploy Preview for wfp-hungermap ready!

Name	Link
🔨 Latest commit	6df6f8a
🔍 Latest deploy log	https://app.netlify.com/sites/wfp-hungermap/deploys/67608dda7ded4d0008589167
😎 Deploy Preview	https://deploy-preview-135--wfp-hungermap.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[marinovl7]

Awesome functionality job! Just few small things needd to be changed! Great job overall!

[Tschonti]

@Tschonti pls check added hooks

hooks LGTM, nice work

some things I noticed:

• some graphs (especially bar charts) only have 0 and 1 as labels on the X-axis
• maybe we could remove the disabled countries from the selection, it's hard to find a selectable country this way
• maybe there could be a button to deselect all the countries quickly
• when there's an error while fetching the data for a country, we should deselect it
• if you select a country, get an error, deselect it, then select it again, you don't get the error again. I know this happens because of the caching of useQuery, but still a bit weird for the user. Not sure what can be done about this, maybe disable the country after it had an error before????

[bohdangarchu]

• some graphs (especially bar charts) only have 0 and 1 as labels on the X-axis

This will change when we integrate bar chart.

• maybe we could remove the disabled countries from the selection, it's hard to find a selectable country this way

True, @marinovl7 what do you think?

• maybe there could be a button to deselect all the countries quickly

Good idea, will look into that

• when there's an error while fetching the data for a country, we should deselect it

Good catch

• if you select a country, get an error, deselect it, then select it again, you don't get the error again. I know this happens because of the caching of useQuery, but still a bit weird for the user. Not sure what can be done about this, maybe disable the country after it had an error before????

Yes, good idea

[bohdangarchu]

@Tschonti we added all features discussed above and also a hook (useSelectedCountries) that syncs selected countries and query params. @marinovl7 your comments are fixed as well

[marinovl7]

@bohdangarchu @jschoedl crazy feature! Thanks a lot for the perfect implementation! The customers will love it and request additional comparison possibilities. Thanks for also thinking about the query params! This way we could send links to the direct comparison of some countries. Awesome!