Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode redesign #1893

Merged
merged 5 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions report-viewer/src/components/ComparisonsTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ import { DynamicScroller, DynamicScrollerItem } from 'vue-virtual-scroller'
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
import { library } from '@fortawesome/fontawesome-svg-core'
import { faUserGroup } from '@fortawesome/free-solid-svg-icons'
import { generateColors } from '@/utils/ColorUtils'
import { generateHues } from '@/utils/ColorUtils'
import ToolTipComponent from './ToolTipComponent.vue'
import { MetricType, metricToolTips } from '@/model/MetricType'
import NameElement from './NameElement.vue'
Expand Down Expand Up @@ -339,10 +339,25 @@ function getClusterFor(clusterIndex: number) {

const displayClusters = props.clusters != undefined

let clusterIconColors = [] as Array<string>
let clusterIconHues = [] as Array<number>
const lightmodeSaturation = 80
const lightmodeLightness = 50
const lightmodeAlpha = 0.3
const darkmodeSaturation = 90
const darkmodeLightness = 65
const darkmodeAlpha = 0.6
if (props.clusters != undefined) {
clusterIconColors = generateColors(props.clusters.length, 0.8, 0.5, 1)
clusterIconHues = generateHues(props.clusters.length)
}
const clusterIconColors = computed(() =>
clusterIconHues.map((h) => {
return `hsla(${h}, ${
store().uiState.useDarkMode ? darkmodeSaturation : lightmodeSaturation
}%, ${
store().uiState.useDarkMode ? darkmodeLightness : lightmodeLightness
}%, ${store().uiState.useDarkMode ? darkmodeAlpha : lightmodeAlpha})`
})
)

function isHighlightedRow(item: ComparisonListElement) {
return (
Expand Down
2 changes: 1 addition & 1 deletion report-viewer/src/components/ContainerComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
-->
<template>
<div
class="box-border rounded-md border-1 border-container-border-light bg-container-light p-2 shadow dark:border-container-border-dark dark:bg-container-dark dark:shadow-black print:border-2 print:shadow-none"
class="box-border rounded-md border-1 border-container-border-light bg-container-light p-2 shadow dark:border-container-border-dark dark:bg-container-dark print:border-2 print:shadow-none"
>
<slot></slot>
</div>
Expand Down
34 changes: 8 additions & 26 deletions report-viewer/src/utils/ColorUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,15 @@ import { computed } from 'vue'
/**
* Generates an array of HSL-Colors
* @param numberOfColors Number of colors to generate
* @param saturation Saturation of the colors [0,1]
* @param lightness Lightness of the colors [0,1]
* @param alpha Alpha value of the colors [0,1]
*/
function generateColors(
numberOfColors: number,
saturation: number,
lightness: number,
alpha: number
) {
function generateHues(numberOfColors: number) {
const numberOfColorsInFirstInterval = Math.round(
((80 - 20) / (80 - 20 + (340 - 160))) * numberOfColors
) // number of colors from the first interval
const numberOfColorsInSecondInterval = numberOfColors - numberOfColorsInFirstInterval // number of colors from the second interval

const colors: Array<string> = generateColorsForInterval(
20,
80,
numberOfColorsInFirstInterval,
saturation,
lightness,
alpha
)
colors.push(...generateColorsForInterval(160, 340, numberOfColorsInSecondInterval, 0.8, 0.5, 0.3))
const colors: Array<number> = generateColorsForInterval(20, 80, numberOfColorsInFirstInterval)
colors.push(...generateColorsForInterval(160, 340, numberOfColorsInSecondInterval))
return colors
}

Expand All @@ -44,19 +29,16 @@ function generateColors(
function generateColorsForInterval(
intervalStart: number,
intervalEnd: number,
numberOfColorsInInterval: number,
saturation: number,
lightness: number,
alpha: number
numberOfColorsInInterval: number
) {
const colors: Array<string> = []
const hues: Array<number> = []
const interval = intervalEnd - intervalStart
const hueDelta = Math.trunc(interval / numberOfColorsInInterval)
for (let i = 0; i < numberOfColorsInInterval; i++) {
const hue = intervalStart + i * hueDelta
colors.push(`hsla(${hue}, ${saturation * 100}%, ${lightness * 100}%, ${alpha})`)
hues.push(hue)
}
return colors
return hues
}

/** This is the list of colors that are used as the background color of matches in the comparison view */
Expand Down Expand Up @@ -113,4 +95,4 @@ const graphColors = {
}
}

export { generateColors, graphColors, getMatchColorCount, getMatchColor, type MatchColorIndex }
export { generateHues, graphColors, getMatchColorCount, getMatchColor, type MatchColorIndex }
10 changes: 5 additions & 5 deletions report-viewer/tailwind.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@ export default {
},
background: {
light: 'hsl(0, 0%, 97%)',
dark: 'hsl(180, 80%, 3%)'
dark: 'hsl(230, 10%, 8%)'
},
container: {
light: 'hsl(0, 0%, 98%)',
dark: 'hsl(200, 20%, 13%)',
dark: 'hsl(250, 10%, 15%)',
border: {
light: 'hsl(0, 0%, 80%)',
dark: 'hsl(0, 0%, 25%)'
},
secondary: {
light: 'hsl(0, 0%, 95%)',
dark: 'hsl(200, 20%, 18%)'
dark: 'hsl(250, 10%, 20%)'
}
},
interactable: {
light: 'hsl(0, 0%, 100%)',
dark: 'hsl(180, 30%, 18%)',
dark: 'hsl(250, 10%, 20%)',
border: {
light: 'hsl(0, 0%, 75%)',
dark: 'hsl(0, 0%, 30%)'
dark: 'hsl(0, 0%, 25%)'
}
},
scrollbar: {
Expand Down