Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode redesign #1893

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Dark mode redesign #1893

merged 5 commits into from
Sep 5, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 30, 2024 •
edited
Loading

This PR updates the dark mode colors

grafik
grafik
grafik
grafik

@Kr0nox Kr0nox changed the base branch from main to develop July 30, 2024 08:47
@Kr0nox Kr0nox changed the title Report viewer/dark mode redesign Dark mode redesign Jul 30, 2024
@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Jul 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jplag jplag deleted a comment from sonarqubecloud bot Jul 30, 2024
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jul 31, 2024
@Kr0nox Kr0nox added this to the 6.0.0 milestone Aug 4, 2024
@Kr0nox Kr0nox marked this pull request as ready for review August 29, 2024 11:41
@dfuchss
Copy link
Member

dfuchss commented Aug 30, 2024

I think the colors for the cluster (in the overview) could be more visible :)

@Kr0nox
Copy link
Member Author

Kr0nox commented Aug 31, 2024

I think the colors for the cluster (in the overview) could be more visible :)

Do these work better?
grafik

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit 5776afa into develop Sep 5, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @dfuchss @tsaglam