Update getName method in used in Language class #1767
Conversation
Shortened getName() return.
Shortened getName() return.
| @@ -25,7 +25,7 @@ public String[] suffixes() { | |||
|
|
|||
| @Override | |||
| public String getName() { | |||
| return NAME; | |||
| return "C#"; | |||
There was a problem hiding this comment.
With this change, you produce inconsistencies with the name constant. You should probably just adapt the constant value instead.
tsaglam
added
enhancement
|
Just as general feedback, while granular committing is great, your commits are very atomic, meaning they encapsulate very few changes, which would make them generally considered a bit too fine-grained. This is not a problem for this PR though, as I can squash on merge. |
tsaglam
added
the
language
|
|
You will also need to update all names here https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts |
I see this as a v6.0.0 feature, we can probably just merge this after the v5.1.0 release. |
Ok I'll do this! |
|
wait a second. i forked the main branch not develop so I cant find https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts Should I close this pull request and make a new one with the right branch? |
Hi! This pull request does everything that issue #1497 asks for, which is to clean up the getName() methods of many of the languages. Now they just will return the language name and not the parser name. Please tell me if I did anything wrong or if I have to change anything. Thanks a lot!