Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of getName method of Langauge #1497

Closed
Kr0nox opened this issue Jan 23, 2024 · 2 comments
Closed

Use of getName method of Langauge #1497

Kr0nox opened this issue Jan 23, 2024 · 2 comments
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Milestone
6.0.0

Comments

@Kr0nox
Copy link
Member

Kr0nox commented Jan 23, 2024

Currently the getName method of the Language class returns the name of the Parser for most languages. This could be changed to just return the name of the language.
This would also shorten the language list message printed on the start of the CLI
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Jan 25, 2024
@Mintype Mintype mentioned this issue May 16, 2024
Closed
@Mintype
Copy link

Mintype commented May 16, 2024

I think my pull request will solve this issue.

@Kr0nox Kr0nox linked a pull request May 18, 2024 that will close this issue
Update getName method in used in Language class #1767
Closed
@Mintype Mintype mentioned this issue May 18, 2024
Closed
@Kr0nox Kr0nox linked a pull request May 21, 2024 that will close this issue
Shorten Languages in getName() method. #1769
Closed
@TwoOfTwelve TwoOfTwelve added this to the 6.0.0 milestone Aug 1, 2024
@Kr0nox Kr0nox mentioned this issue Aug 3, 2024
Merged
@github-actions GitHub Actions
Copy link

Closed by #1902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
6.0.0
4 participants
@tsaglam @Kr0nox @Mintype @TwoOfTwelve