Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Change Morlet cycles for better alpha #928

Merged
merged 2 commits into from
Nov 7, 2024
Merged

hotfix: Change Morlet cycles for better alpha #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99a879
hotfix: Change Morlet cycles for better alpha
asoplata Nov 6, 2024
c0779ae
fix: lengthen spect tests so default wavelets pass
asoplata Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hnn_core/gui/_viz_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def _update_ax(fig, ax, single_simulation, sim_name, plot_type, plot_config):
max_f = plot_config['max_spectral_frequency']
step_f = 1.0
freqs = np.arange(min_f, max_f, step_f)
n_cycles = freqs / 8.
n_cycles = freqs / 2.
dpls_copied[0].plot_tfr_morlet(
freqs,
n_cycles=n_cycles,
Expand Down
4 changes: 4 additions & 0 deletions hnn_core/tests/test_gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,8 @@ def test_gui_add_data_dependent_figure(setup_gui):
axes_config_tabs = gui.viz_manager.axes_config_tabs
assert len(fig_tabs.children) == 0
assert len(axes_config_tabs.children) == 0
# Spectrogram needs longer time for wavelet analysis
gui.widget_tstop.value = 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that this doesn't impact test length, but FYI we've discussed previously adding a hard limit to unit test runtime


# after each run we should have a default fig
gui.run_button.click()
Expand Down Expand Up @@ -655,6 +657,8 @@ def test_gui_visualization(setup_gui):
"""Tests updating a figure creates plots with data."""

gui = setup_gui
# Spectrogram needs longer time for wavelet analysis
gui.widget_tstop.value = 500
gui.run_button.click()

gui._simulate_viz_action("switch_fig_template", "[Blank] single figure")
Expand Down
Loading