Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Change Morlet cycles for better alpha #928

Merged

Conversation

asoplata
Copy link
Collaborator

@asoplata asoplata commented Nov 6, 2024

This is primarily being changed for the upcoming Alpha and Beta tutorials

This is primarily being changed for the upcoming Alpha and Beta
tutorials
@asoplata asoplata force-pushed the change_default_spect_props branch from 80c43d3 to d9a5efe Compare November 7, 2024 15:58
@asoplata asoplata force-pushed the change_default_spect_props branch from d9a5efe to c0779ae Compare November 7, 2024 16:04
@@ -513,6 +513,8 @@ def test_gui_add_data_dependent_figure(setup_gui):
axes_config_tabs = gui.viz_manager.axes_config_tabs
assert len(fig_tabs.children) == 0
assert len(axes_config_tabs.children) == 0
# Spectrogram needs longer time for wavelet analysis
gui.widget_tstop.value = 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that this doesn't impact test length, but FYI we've discussed previously adding a hard limit to unit test runtime

Copy link
Contributor

@ntolley ntolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @asoplata!!

Happy to merge if it's all good with you

@asoplata asoplata merged commit 0eedf3c into jonescompneurolab:master Nov 7, 2024
12 checks passed
@asoplata asoplata deleted the change_default_spect_props branch November 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants