Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG]: Add cell parameters in GUI #806

Merged
merged 26 commits into from
Jul 13, 2024
Merged

[MRG]: Add cell parameters in GUI #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b864036
ENH: Modified connectivity tab to contain two additional tabs
kmilo9999 Jul 3, 2024
8eb339b
MAINT: Fixed spellcheck and linkcheck erros in gui.py
kmilo9999 Jul 7, 2024
2231a4c
MAINT: Fixed bad argument in on_upload_params_change
kmilo9999 Jul 7, 2024
ff78e98
MAINT: Fixed bad argument in on_upload_params_change
kmilo9999 Jul 7, 2024
525efbb
MAINT: Fixed notebook tutorial that looks up tabs by name
kmilo9999 Jul 7, 2024
21f048c
MAINT: Fixed description width in cell parameters gui tab
kmilo9999 Jul 8, 2024
8d1545d
STY: Fixed flake8 errors
kmilo9999 Jul 8, 2024
41e74bb
MAINT: Adding cell types keys to gui cell params map
kmilo9999 Jul 9, 2024
56f758f
MAINT: Added default values for gui cell params floatfields
kmilo9999 Jul 9, 2024
6a9a861
MAINT: Setting up cell params on run simulation button clicked
kmilo9999 Jul 10, 2024
9f69ac4
MAINT: Fixing L5 Biophysics cell params input and gui test cases
kmilo9999 Jul 10, 2024
6b55758
TST: Adding test for gui cell params
kmilo9999 Jul 10, 2024
0c6b30a
MAINT: Removing commented code and debuggy dev import
kmilo9999 Jul 10, 2024
5ed3317
MAINT: Removing unsued code
kmilo9999 Jul 10, 2024
c70f920
MAINT: increase cell params textfields
kmilo9999 Jul 10, 2024
70aae46
MAINT: increased gui cell params description width to fix large label
kmilo9999 Jul 10, 2024
d646b74
STY: Added the word pyramidal to the cell types radio buttons
kmilo9999 Jul 10, 2024
39b33c9
STY: Fixed typo in variable
kmilo9999 Jul 10, 2024
e4f7cbd
MAINT: Removed debuggy init code
kmilo9999 Jul 10, 2024
e9bc7ff
MAINT: Applied comments in review
kmilo9999 Jul 10, 2024
114dcfc
MAINT: Refactoing code due to the change in cell type radio buttons l…
kmilo9999 Jul 11, 2024
94b61b8
TST: Fixing gui cell params pytest
kmilo9999 Jul 11, 2024
62b880e
MAINT: Updating dendrite sections using properties loop instead of ha…
kmilo9999 Jul 11, 2024
3f1abf5
DOC: Added cell params feature entry in whats_new.rst
kmilo9999 Jul 12, 2024
1274677
MAINT: Fixing python code in test_gui.py
kmilo9999 Jul 12, 2024
fd78a36
MAINT: Fixing python code in test_gui.py
kmilo9999 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion doc/gui/tutorial_erp.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,20 @@
"%autoreload 2"
]
},
{
"cell_type": "markdown",
"id": "b446910e",
"metadata": {},
"source": []
},
{
"cell_type": "code",
"execution_count": null,
"id": "82e9a552",
"metadata": {},
"outputs": [],
"source": []
},
{
"cell_type": "markdown",
"id": "a0dd997d",
Expand Down Expand Up @@ -220,7 +234,7 @@
"metadata": {},
"outputs": [],
"source": [
"gui._simulate_left_tab_click(\"Network connectivity\")"
"gui._simulate_left_tab_click(\"Network\")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to move away from the automatically generated GUI documentation so not necessary to update this file (no need to remove this change of course)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of the tests fails if the 'Network Connectivity' tab title changes but it's not updated in the notebook.

]
},
{
Expand Down
4 changes: 4 additions & 0 deletions doc/whats_new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ Changelog
- Updated `plot_spikes_raster` logic to include all neurons in network model.
Removed GUI exclusion from build, by `Abdul Samad Siddiqui`_ in :gh:`754`.

- Added GUI feature to read and modify cell parameters,
by `Camilo Diaz`_ in :gh:`806`.


Bug
~~~
- Fix inconsistent connection mapping from drive gids to cell gids, by
Expand Down
Loading
Loading