Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update to Python>=3.8 #678

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

rythorpe
Copy link
Contributor

The latest releases of Matplotlib now require Python>=3.8. This updates our tests and installers correspondingly.

@rythorpe rythorpe force-pushed the dependency_updates branch from 9ae9f6b to b524213 Compare October 3, 2023 04:19
@rythorpe rythorpe changed the title [WIP] update to Python>=3.8 [MRG] update to Python>=3.8 Oct 3, 2023
@rythorpe rythorpe force-pushed the dependency_updates branch from 49080b9 to a401ce5 Compare October 3, 2023 04:56
@rythorpe
Copy link
Contributor Author

rythorpe commented Oct 3, 2023

Okay, I'm pretty sure everything should pass now. Feel free to squash and merge if/when it does @ntolley @jasmainak so we can build and update our docs on master.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (91b8ff6) 91.42% compared to head (4d5ccf4) 91.38%.

❗ Current head 4d5ccf4 differs from pull request most recent head 9205e61. Consider uploading reports for the commit 9205e61 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   91.42%   91.38%   -0.04%     
==========================================
  Files          25       25              
  Lines        4604     4599       -5     
==========================================
- Hits         4209     4203       -6     
- Misses        395      396       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

else
conda install --yes mpi4py openmpi
fi
conda install --yes -c conda-forge mpi4py openmpi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was changed because the mpi4py installation was failing for Ubuntu/Python 3.9. Not totally sure what the root of the issue was.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the default repository identified for the conda install had an old/incompatible version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like that. We technically shouldn't need to install the openmpi python library on Linux if it's already installed at the system level, but now we can just rely on wheels that are compiled and tested by the maintainers of mpi4py.

@jasmainak jasmainak enabled auto-merge (rebase) October 4, 2023 00:12
@jasmainak
Copy link
Collaborator

I enabled auto-merge. Thanks a lot @rythorpe !! 🎉

@rythorpe
Copy link
Contributor Author

rythorpe commented Oct 4, 2023

How do we change the merge requirements @jasmainak? Right now you're the only one who can approve merges or enable auto-merges.

@jasmainak jasmainak disabled auto-merge October 4, 2023 11:15
@jasmainak
Copy link
Collaborator

Umm ... I think anyone with merge rights can enable auto-merges ... but if the CIs are not passing, you have to select "Merge without waiting for requirements to be met". I would select this sparingly though ...

@jasmainak
Copy link
Collaborator

The macos build seems to be stuck for whatever reason ...

@rythorpe
Copy link
Contributor Author

rythorpe commented Oct 4, 2023

Did you disable auto-merge on purpose @jasmainak, or did it cancel when you modified the branch protection rules?

@rythorpe rythorpe merged commit 7bebb00 into jonescompneurolab:master Oct 4, 2023
7 checks passed
@rythorpe
Copy link
Contributor Author

rythorpe commented Oct 4, 2023

I'm guessing it just cancelled on its own so I went ahead and merged it 🚀

@rythorpe rythorpe deleted the dependency_updates branch October 4, 2023 16:02
@jasmainak
Copy link
Collaborator

Thanks @rythorpe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants