-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update to Python>=3.8 #678
[MRG] update to Python>=3.8 #678
Conversation
9ae9f6b
to
b524213
Compare
49080b9
to
a401ce5
Compare
Okay, I'm pretty sure everything should pass now. Feel free to squash and merge if/when it does @ntolley @jasmainak so we can build and update our docs on master. |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 91.42% 91.38% -0.04%
==========================================
Files 25 25
Lines 4604 4599 -5
==========================================
- Hits 4209 4203 -6
- Misses 395 396 +1 ☔ View full report in Codecov by Sentry. |
else | ||
conda install --yes mpi4py openmpi | ||
fi | ||
conda install --yes -c conda-forge mpi4py openmpi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this was changed because the mpi4py installation was failing for Ubuntu/Python 3.9. Not totally sure what the root of the issue was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the default repository identified for the conda install had an old/incompatible version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like that. We technically shouldn't need to install the openmpi python library on Linux if it's already installed at the system level, but now we can just rely on wheels that are compiled and tested by the maintainers of mpi4py.
I enabled auto-merge. Thanks a lot @rythorpe !! 🎉 |
How do we change the merge requirements @jasmainak? Right now you're the only one who can approve merges or enable auto-merges. |
Umm ... I think anyone with merge rights can enable auto-merges ... but if the CIs are not passing, you have to select "Merge without waiting for requirements to be met". I would select this sparingly though ... |
The macos build seems to be stuck for whatever reason ... |
Did you disable auto-merge on purpose @jasmainak, or did it cancel when you modified the branch protection rules? |
I'm guessing it just cancelled on its own so I went ahead and merged it 🚀 |
Thanks @rythorpe ! |
The latest releases of Matplotlib now require Python>=3.8. This updates our tests and installers correspondingly.