[FIX] refactor dingz.updateAccessory

[johannrichard]

Describe the enhancement
The updateAccessory() method of the dingz accessory needs refactoring:

• integrate updating of the Accessory metadata (FW, Serial, Name etc.)
• call DingzEvent.UPDATE_INFO to initiate an accessory Update
• untangle some of the intertwined code snippets that doe (almost) the same thing e.g. in getDingzDeviceInfo() and platform.getDingzDeviceInfo

Examples and context

homebridge-dingz/src/dingzAccessory.ts

Lines 1126 to 1156 in f33d1de

	private async updateAccessory(): Promise<void> {
	this.platform.log.info(
	'Update accessory ',
	this.device.address,
	'-> Check for changed config.',
	);
	this.getConfigs().then(([inputConfig, dimmerConfig]) => {
	if (inputConfig?.inputs[0]) {
	this._updatedDeviceInputConfig = inputConfig.inputs[0];
	}
	this.device.dimmerConfig = dimmerConfig;
	});
	this.getDingzDeviceInfo().then((deviceInfo) => {
	this._updatedDeviceInfo = deviceInfo;
	});
	let updatedDingzDeviceInfo: DingzDeviceInfo | undefined;
	let updatedDingzInputInfo: DingzInputInfoItem | undefined;
	try {
	const currentDingzDeviceInfo: DingzDeviceInfo = this.accessory.context
	.device.dingzDeviceInfo;
	updatedDingzDeviceInfo =
	this._updatedDeviceInfo ?? currentDingzDeviceInfo;
	if (
	currentDingzDeviceInfo &&
	currentDingzDeviceInfo.has_pir !== updatedDingzDeviceInfo.has_pir
	) {

[johannrichard]

Issues #116, #118, #120 and #123 are all related to the fact that this part of the code is still quite a mess.

I will therefore do two things:

• Deprecate (or even remove) v1.8.0 of the extension (falling back to v1.7.1 which is working)
• Refactor the code such that updates of the accessories and their states across all device types (i.e. myStrom and dingz)

I hope this will eventually solve these issues and cure the sick patient that v1.8.0 has become. 🤒🤕

[johannrichard]

Also of importance to all this:

homebridge/HAP-NodeJS#543

[johannrichard]

Things to be fixed in updateAccessory():

• add / remove 'not_connected' dimmers
• better / simpler handling of dimmers

Question: must we call this method really regularly or would it be sufficient to update on start?