-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read WindowCoveringConfig and set correct names #127
Conversation
granturism0
commented
Nov 22, 2020
- Implementation of WindowCoveringConfig
- Setting the names for blinds using the WebGUI
- Improvement detection of IP changes
@granturism0 thanks again for the contributions, will have a more thorough look at them. After a quick glance, let me offer a few observations:
|
PS: You might also want to check-out the |
Sorry, about the style errors. I will correct them in some minutes |
PPS: No problem, my setup is quite strict in terms of code formatting. Just a hint: you don't have to close the PR's for new commits. New commits from the same branch you develop in will be added to the PR as long as the PR is open, so you can just continue to work on the code and commit without opening a new PR. This is quite handy if code-reviews / changes are requested before merging. |