Skip to content

Commit

Permalink
style(*): clean-up todo's and fixme's in code
Browse files Browse the repository at this point in the history
- remove reference to #103, #116, #120, #123 (all implemented by now)
  • Loading branch information
johannrichard committed Dec 12, 2020
1 parent d3282c1 commit 394a8e5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/dingzAccessory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ export class DingzAccessory extends DingzDaBaseAccessory {
}

// Get updated device info and update the corresponding values
// TODO: #103, #116, #120, #123 -- fetch state for all device elements
protected getDeviceStateUpdate(): Promise<void> {
return this.getDeviceState()
.then((state) => {
Expand All @@ -270,7 +269,6 @@ export class DingzAccessory extends DingzDaBaseAccessory {
this.dingzStates.Temperature = state.sensors.room_temperature;
this.dingzStates.Brightness = state.sensors.brightness;
// Lamellas
// TODO: assign right values
this.dingzStates.WindowCovers = state.blinds;

if (
Expand Down Expand Up @@ -844,7 +842,6 @@ export class DingzAccessory extends DingzDaBaseAccessory {
}

// Window Covering functions
// TODO: Use available information to more accurately set WindowCovering State
private updateWindowCoveringState(
index: WindowCoveringIndex,
service: Service,
Expand Down Expand Up @@ -1482,7 +1479,6 @@ export class DingzAccessory extends DingzDaBaseAccessory {
});
}

// TODO: Feedback on API doc
/**
* Set the LED on the dingz
* @param callback: Characteristic callback
Expand Down
1 change: 0 additions & 1 deletion src/lib/dingzTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ export type WindowCoveringProps = Record<
WindowCoveringState
>;

// FIXME: #103 Replace dispersed data gathering with `api/v1/state` endpoint
export interface DingzState {
dimmers: DimmerState[];
blinds: WindowCoveringStates[];
Expand Down
1 change: 0 additions & 1 deletion src/myStromPIRAccessory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ export class MyStromPIRAccessory extends DingzDaBaseAccessory {
}

// If we are in motion polling mode, update motion from poller
// TODO: remove this -- doesn't make sense at all
if (this.platform.config.motionPoller ?? true) {
this.log.info('Motion POLLING of', this.device.name, 'enabled');
const isMotion: boolean = report.motion;
Expand Down
2 changes: 0 additions & 2 deletions src/platform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ import {
STATE_UPDATE_INTERVAL,
} from './settings';

// TODO: Some refactoring for better event handling, cleanup of the code and separation of concerns
import { PlatformEventBus, PlatformEvent } from './lib/platformEventBus';

// Accessory classes
Expand Down Expand Up @@ -146,7 +145,6 @@ export class DingzDaHomebridgePlatform implements DynamicPlatformPlugin {
accessory.context.device.accessoryClass,
);

// TODO: Remove the device if it has vanished for too long (i.e. restore was not possible for a long time)
const context = accessory.context;
if (context.device && context.device.accessoryClass) {
this.log.debug(
Expand Down

0 comments on commit 394a8e5

Please sign in to comment.