support for custom API requests #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joan38
reviewed
Nov 1, 2023
| headers = request.headers, | ||
| body = request.body, | ||
| attributes = request.attributes | ||
| ).withOptionalAuthorization(authorization) |
There was a problem hiding this comment.
Why not using a copy here like below?
There was a problem hiding this comment.
http4s' Request is a final class (not case class) thus it doesn't provide the .copy methods unfortunately.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two helper methods in the client:
def customRequest(request: Request[F]): F[Request[F]]anddef customRequest(request: WSRequest): F[WSRequest]These methods update the provided request by setting the API hostname and adding the authorization.
This should help us more easily use other k8s API endpoints that are not explicitly supported by this library.
(Not having these, I had to do some "hacking" in order to use the logs endpoint in our code, like defining an object inside the
com.goyeau.kubernetes.clientpackage in order to get access to.withOptionalAuthorizationand some other things).