better raw requests #260
Merged
better raw requests #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this similar to the |
|
Ah nevermind you are replacing it with that. Cool I like this approche much more. |
joan38
approved these changes
Nov 24, 2023
|
@yurique We can merge this one too |
|
Great I will make a release now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #246 - the solution there was incomplete (and, admittedly, not very well thought through).
For example, if the underlying http client happens to be configured with an SSL context - the user will be stuck, since we only prepare the request for them, but they still don't have access to the http client to run it with.
Here, I introduced a new "module" to the kubernetes client:
RawApi(client.raw) which exposes two methods:runRequestconnectWSThose methods will prepare and execute the requests, but leave the handling of the responses to the user's discretion.