Skip to content

Commit

Permalink
Update given CRAN maintainer comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jluchman committed May 7, 2022
1 parent 2759dfb commit e6fae39
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Imports:
stats,
utils
Suggests:
dominanceanalysis,
testthat (>= 3.0.0),
relaimpo,
yhat,
Expand Down
26 changes: 14 additions & 12 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This patch version update corrects warnings from R-devel checks from Linux platforms on CRAN related to: "domir-package.Rd:30: invalid email address: [jluchman\@gmail](mailto:jluchman@gmail){.email}\_com".

In addition, this patch version update corrects the note from R-devel and R-patched checks on CRAN, along with a request from CRAN maintainers in the previous submission, related to: "Package suggested but not available for checking: 'dominanceanalysis'".

Changes from version 0.3.0 also include:

- Minor updates and editorial corrections to *Conceptual Introduction to Dominance Analysis* vignette
Expand All @@ -16,16 +18,6 @@ Changes from version 0.3.0 also include:

## R CMD check results

Fedora Linux, R-devel, clang, gfortran (rhub): 1 ERROR

checking package dependencies ... ERROR Packages suggested but not available: 'relaimpo', 'tidyverse'

The suggested packages are required for a complete check. Checking can be attempted without them by setting the environment variable *R_CHECK_FORCE_SUGGESTS* to a false value.

See section 'The DESCRIPTION file' in the 'Writing R Extensions' manual.

Comment: CRAN checks last updated on 2022-05-01 16:52:10 CEST for r-devel-linux-x86_64-debian-gcc for `relaimpo`, a suggested package in `domir`, show dependency `survey` is not available. Similarly, CRAN checks last updated on 2022-05-01 16:52:10 CEST for r-devel-linux-x86_64-debian-gcc for `tidyverse`, also a suggested package in `domir`, show dependencies `haven` and `readr` is not available. Given the nature of the error, I do not believe the problem stems from the `domir` package.

Windows Server 2022, R-devel, 64 bit (rhub): 1 NOTE

* checking for detritus in the temp directory ... NOTE
Expand All @@ -36,9 +28,19 @@ Comment: Appears to be an issue with TeX on this platform. I cannot reproduce th

win-builder (devel, release, and old-release): 1 NOTE

Found the following (possibly) invalid DOIs: DOI: 10.1037/1082-989X.8.2.129
Found the following (possibly) invalid DOIs:
DOI: 10.1037/1082-989X.8.2.129
From: DESCRIPTION
Status: Bad Request
Message: 400
DOI: 10.1198/000313007X188252
From: DESCRIPTION
Status: Service Unavailable
Message: 503

Comment: DOI: 10.1037/1082-989X.8.2.129 links reliably to Azen and Budescu's 2003 article on dominance analysis when followed from a web browser (tested on Google Chrome and Mozilla Firefox).

Comment: This DOI is not invalid and reliably links to Budescu's 1993 article on dominance analysis.
Similarly, DOI: 10.1198/000313007X188252 links reliably to Groemping's 2007 article on relative importance in linear models when followed from a web browser (tested on Google Chrome and Mozilla Firefox).

## Downstream dependencies

Expand Down

0 comments on commit e6fae39

Please sign in to comment.