Skip to content

Commit

Permalink
finalize for submission to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
jluchman committed May 1, 2022
1 parent 1228e02 commit 2759dfb
Showing 1 changed file with 33 additions and 18 deletions.
51 changes: 33 additions & 18 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,45 @@
## Minor version update: 0.3.0
This minor version update has included new features and updates to internal computation methods for the `domin` function, a `summary` function that can be called with a `domin` class object, and extensive updates to the vignette introducing the concepts underlying the main function.
## Minor version update: 0.3.1

Changes from version 0.2.0 include:
This patch version update corrects warnings from R-devel checks from Linux platforms on CRAN related to: "domir-package.Rd:30: invalid email address: [jluchman\@gmail](mailto:jluchman@gmail){.email}\_com".

* `conditional` logical argument to make computing conditional dominance statistics optional
* initial working version of `summary.domin`
* method for computing the strongest dominance designations between independent variables
* update to `print.domin` to display strongest dominance designations
* reorganization and update to *Conceptual Introduction to Dominance Analysis* vignette
* looping used to construct many dominance statistics, replaced with matrix-based methods; intended to simplify and expedite computations
Changes from version 0.3.0 also include:

- Minor updates and editorial corrections to *Conceptual Introduction to Dominance Analysis* vignette

## Test environments
* local pop!OS/ubuntu 21.10, R 4.1.2
* Windows Server 2022, R-devel, 64 bit (rhub)
* Ubuntu Linux 20.04.1 LTS, R-release, GCC (rhub)
* Fedora Linux, R-devel, clang, gfortran (rhub)
* win-builder (devel, release, and old-release)

- local pop!OS/ubuntu 21.10, R 4.2.0
- Windows Server 2022, R-devel, 64 bit (rhub)
- Ubuntu Linux 20.04.1 LTS, R-release, GCC (rhub)
- Fedora Linux, R-devel, clang, gfortran (rhub)
- win-builder (devel, release, and old-release)

## R CMD check results

All tests: 1 NOTE
Fedora Linux, R-devel, clang, gfortran (rhub): 1 ERROR

checking package dependencies ... ERROR Packages suggested but not available: 'relaimpo', 'tidyverse'

The suggested packages are required for a complete check. Checking can be attempted without them by setting the environment variable *R_CHECK_FORCE_SUGGESTS* to a false value.

See section 'The DESCRIPTION file' in the 'Writing R Extensions' manual.

Comment: CRAN checks last updated on 2022-05-01 16:52:10 CEST for r-devel-linux-x86_64-debian-gcc for `relaimpo`, a suggested package in `domir`, show dependency `survey` is not available. Similarly, CRAN checks last updated on 2022-05-01 16:52:10 CEST for r-devel-linux-x86_64-debian-gcc for `tidyverse`, also a suggested package in `domir`, show dependencies `haven` and `readr` is not available. Given the nature of the error, I do not believe the problem stems from the `domir` package.

Windows Server 2022, R-devel, 64 bit (rhub): 1 NOTE

* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

Comment: Appears to be an issue with TeX on this platform. I cannot reproduce the error locally.

win-builder (devel, release, and old-release): 1 NOTE

Found the following (possibly) invalid DOIs: DOI: 10.1037/1082-989X.8.2.129

Found the following (possibly) invalid DOIs:
DOI: 10.1037/1082-989X.8.2.129

Comment: This DOI is not invalid and reliably links to Budescu's 1993 article on dominance analysis.

## Downstream dependencies

There are no downstream dependencies for this package.

0 comments on commit 2759dfb

Please sign in to comment.