Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use JJ_LOG to specify log configuration #5112

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

mrnossiom
Copy link
Collaborator

@mrnossiom mrnossiom commented Dec 16, 2024

Using the default RUST_LOG environment variable conflicts when working on unrelated Rust projects.

Supersedes #4350, which is stale.

Closes #4219 #4350

I am unsure whether this has to be listed as a breaking change in the CHANGELOG.

Checklist

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)

Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the topic of first commit should be either cli: or cli_util: <rest-of-description>, as feat is not a known topic in the project, otherwise LG.

Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Collaborator

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍. I had some suggestions, but they're not terribly important.

docs/contributing.md Outdated Show resolved Hide resolved
Using the default `RUST_LOG` env var, conflicts when
working on rust projects.
@mrnossiom mrnossiom merged commit acaf7af into jj-vcs:main Dec 17, 2024
18 checks passed
@mrnossiom mrnossiom deleted the jj-log branch December 17, 2024 00:51
@istudyatuni
Copy link

Linked PR not closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Switch from RUST_LOG to JJ_LOG
4 participants