feat: Use JJ_LOG instead of RUST_LOG for tracing configuration #4350
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Prevents name clashes when working on other Rust projects.
|
This should probably be documented somewhere, but not sure where the best place is. |
Perhaps docs/contributing.md is the best place we have right now |
| @@ -189,7 +189,7 @@ pub struct TracingSubscription { | |||
| } | |||
|
|
|||
| impl TracingSubscription { | |||
| const ENV_VAR_NAME: &str = "JJ_LOG"; | |||
| const ENV_VAR_NAME: &'static str = "JJ_LOG"; | |||
There was a problem hiding this comment.
please squash this into the parent commit
|
I think this would be nice to get in before the 0.21 release, which will happen tomorrow. @theduke Can you squash these commits and re-push? If not I'm happy to do so (and retain your authorship!) and refile them myself, since we disallow the "Squash" button on GitHub. |
|
Hi @theduke. Do you still plan to work on this? |
|
Sorry I dropped the ball here, will get it fixed today. |
|
Superseded by #5112. |
Prevents clashes when working on other Rust projects.
Closes #4219