RFC: switch builtin pager to streampager #4203
Conversation
Cargo.toml
Outdated
| @@ -101,6 +101,7 @@ smallvec = { version = "1.13.2", features = [ | |||
| "const_new", | |||
| "union", | |||
| ] } | |||
| streampager = "0.10.3" | |||
There was a problem hiding this comment.
Perhaps, "CC0-1.0" can be allowed, but I haven't updated the list yet.
https://github.com/martinvonz/jj/actions/runs/10224603116/job/28292547146?pr=4203#step:4:83
|
I would really like a version of IIRC, streampager's interface seemed a bit annoying in parts by default, so we might want to change its default config (or try it out at least). Apart from that, I think this might be great! |
Totally agree, and the stripped-down version exists in Sapling tree. Asked question at markbt/streampager#61 |
This brings lots of old crates as dependency, and some of them aren't needed for our use case. Though streampager looks stable, that's unfortunate.
According to the discussion on Discord, streampager is still maintained. It brings more dependencies, but seems more reliable in our use case. For example, the streampager doesn't consume inputs indefinitely whereas minus does. We can also use OS-level pipe to redirect child stderr to the pager.
yuja
force-pushed
the
push-vwqpwvoxokrt
branch
from
193516d to
7ea0283
Compare
Checklist
If applicable:
CHANGELOG.md