built-in pager: write a message to the user if pager doesn't start #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
pagermessage
branch
2 times, most recently
from
feae28c to
c9685d7
Compare
yuja
reviewed
Aug 2, 2024
ilyagr
force-pushed
the
pagermessage
branch
3 times, most recently
from
6493528 to
cf14489
Compare
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Aug 3, 2024
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
|
(Changed the whole PR design after the discussion with Yuya) |
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Aug 3, 2024
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Aug 3, 2024
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Aug 3, 2024
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
ilyagr
added a commit
to ilyagr/jj
that referenced
this pull request
Aug 3, 2024
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
ilyagr
changed the title
The message is printed at the end, any text sent to the pager before then is lost. See jj-vcs#4197 (comment) for a discussion about why that seems OK.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully improve the experience of users who encounter #4182.
Checklist
If applicable:
CHANGELOG.md