ui: do not write() to channel if builtin pager has terminated #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ilyagr
reviewed
Aug 4, 2024
There was a problem hiding this comment.
Nice! Seems to me like this should work. @ErichDonGubler , WDYT?
In principle, an approach closer to the one from #4187 would give us more control and maybe allow us not to lose output in #4197. I'm not sure it's worth it, especially if we might jump over to streampager anyway.
ilyagr
approved these changes
Aug 4, 2024
ErichDonGubler
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Ahh, I like this much better than #4187. I believe it's more robust, even. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md