cli: migrate "tag list" to template #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I haven't contributed to jj in a while so I'll let someone else approve. This PR seems to do 3 things:
These all seem reasonable to me and are very clearly laid out in this series of commits. I can't judge if the functions are what the jj project wants long-term (whether naming or functionality) so I'll let someone else approve. |
noahmayr
approved these changes
May 1, 2024
|
Thanks. I'll merge this PR after the release. This wouldn't be that useful without branch templating. |
I'm going to add ref_name.target*() template methods so the commit templater can be reused for branches/tags templates. RefTarget could be looked up by (name, kind) pair, but it's simpler to store it in RefName.
It will be called from cmd_tag_list().
I'll update the test to include conflicted tag, which can't be easily set up by fetching from remote.
I'm going to add more detailed output there. This is a step towards "branch list" template. "tag list -T" wouldn't be that useful, but it shares primitives with "branch list -T".
"working_copy tag" wouldn't be needed, but is added for consistency.
I considered adding RefTarget template type, but some of the methods naturally fit to RefName. For example, a conflicted branch name is decorated as "??", so it makes sense to add branch.conflict() instead of branch.target().conflict(). I'm not pretty sure how many RefName methods we'll need to add to port the current branch listing, but there will be .tracked(), .tracking_local_present(), .ahead_by(), and .behind_by().
This is basically a template version of print_branch_target().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md