cli: show commit summary in "tag list"

This is basically a template version of print_branch_target().
jj-vcs · Apr 29, 2024 · 16d2a3e · 16d2a3e
1 parent 1568e03
commit 16d2a3e
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -68,6 +68,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Commit objects in templates now have a `contained_in(revset: String) ->
   Boolean` method.
 
+* `jj tag list` now prints commit summary along with the tag name.
+
 ### Fixed bugs
 
 * Revsets now support `\`-escapes in string literal.

diff --git a/cli/src/config/templates.toml b/cli/src/config/templates.toml
@@ -18,7 +18,7 @@ op_log = 'builtin_op_log_compact'
 show = 'builtin_log_detailed'
 
 tag_list = '''
-label("tag", name) ++ "\n"
+label("tag", name) ++ format_ref_targets(self) ++ "\n"
 '''
 
 [template-aliases]
@@ -147,6 +147,17 @@ separate(" ",
 ) ++ "\n"
 '''
 
+'format_ref_targets(ref)' = '''
+if(ref.conflict(),
+  separate("\n",
+    " " ++ label("conflict", "(conflicted)") ++ ":",
+    ref.removed_targets().map(|c| "  - " ++ format_commit_summary_with_refs(c, "")).join("\n"),
+    ref.added_targets().map(|c| "  + " ++ format_commit_summary_with_refs(c, "")).join("\n"),
+  ),
+  ": " ++ format_commit_summary_with_refs(ref.normal_target(), ""),
+)
+'''
+
 'format_operation(op)' = '''
   concat(
     separate(" ", op.id().short(), op.user(), format_time_range(op.time())), "\n",

diff --git a/cli/tests/test_tag_command.rs b/cli/tests/test_tag_command.rs
@@ -52,30 +52,36 @@ fn test_tag_list() {
     insta::assert_snapshot!(
         test_env.jj_cmd_success(&repo_path, &["tag", "list"]),
         @r###"
-    conflicted_tag
-    test_tag
-    test_tag2
+    conflicted_tag (conflicted):
+      - rlvkpnrz caf975d0 (empty) commit1
+      + zsuskuln 3db783e0 (empty) commit2
+      + royxmykx 68d950ce (empty) commit3
+    test_tag: rlvkpnrz caf975d0 (empty) commit1
+    test_tag2: zsuskuln 3db783e0 (empty) commit2
     "###);
 
     insta::assert_snapshot!(
         test_env.jj_cmd_success(&repo_path, &["tag", "list", "--color=always"]),
         @r###"
-    [38;5;5mconflicted_tag[39m
-    [38;5;5mtest_tag[39m
-    [38;5;5mtest_tag2[39m
+    [38;5;5mconflicted_tag[39m [38;5;1m(conflicted)[39m:
+      - [1m[38;5;5mrl[0m[38;5;8mvkpnrz[39m [1m[38;5;4mc[0m[38;5;8maf975d0[39m [38;5;2m(empty)[39m commit1
+      + [1m[38;5;5mzs[0m[38;5;8muskuln[39m [1m[38;5;4m3[0m[38;5;8mdb783e0[39m [38;5;2m(empty)[39m commit2
+      + [1m[38;5;5mr[0m[38;5;8moyxmykx[39m [1m[38;5;4m6[0m[38;5;8m8d950ce[39m [38;5;2m(empty)[39m commit3
+    [38;5;5mtest_tag[39m: [1m[38;5;5mrl[0m[38;5;8mvkpnrz[39m [1m[38;5;4mc[0m[38;5;8maf975d0[39m [38;5;2m(empty)[39m commit1
+    [38;5;5mtest_tag2[39m: [1m[38;5;5mzs[0m[38;5;8muskuln[39m [1m[38;5;4m3[0m[38;5;8mdb783e0[39m [38;5;2m(empty)[39m commit2
     "###);
 
     // Test pattern matching.
     insta::assert_snapshot!(
         test_env.jj_cmd_success(&repo_path, &["tag", "list", "test_tag2"]),
         @r###"
-    test_tag2
+    test_tag2: zsuskuln 3db783e0 (empty) commit2
     "###);
 
     insta::assert_snapshot!(
         test_env.jj_cmd_success(&repo_path, &["tag", "list", "glob:test_tag?"]),
         @r###"
-    test_tag2
+    test_tag2: zsuskuln 3db783e0 (empty) commit2
     "###);
 
     let template = r#"