Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Refactor workspace root directory creation #2829

Merged
merged 1 commit into from
Feb 3, 2024
Merged

cli: Refactor workspace root directory creation #2829

merged 1 commit into from
Feb 3, 2024

Conversation

essiene
Copy link
Collaborator

@essiene essiene commented Jan 15, 2024 •
edited
Loading

Split from #2807

  • Refactor out file_util::create_or_reuse_dir() which will be used by all 'init' functionality to create the repo root directory.

@essiene essiene requested a review from yuja January 15, 2024 20:30
@essiene essiene mentioned this pull request Jan 15, 2024
Merged
1 task
@essiene essiene changed the title no-op: Refactor workspace root directory creation cli: Refactor workspace root directory creation Jan 16, 2024
@essiene essiene requested a review from martinvonz January 16, 2024 10:54
yuja
yuja reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the commit message needs to be update:

  • Add Workspace::create_workspace_root() which is needed by all init

lib/src/file_util.rs Outdated Show resolved Hide resolved
lib/src/file_util.rs Outdated Show resolved Hide resolved
@essiene essiene force-pushed the essiene/2747/1 branch 2 times, most recently from 47ae233 to b284701 Compare February 2, 2024 23:35
@essiene
Copy link
Collaborator Author

essiene commented Feb 2, 2024

Nit: the commit message needs to be update:

  • Add Workspace::create_workspace_root() which is needed by all init

Fixed. Thanks.

@essiene essiene requested a review from yuja February 2, 2024 23:42
yuja
yuja approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/src/file_util.rs Outdated Show resolved Hide resolved
@essiene
cli: Refactor workspace root directory creation
189978b 
* Add file_util::create_or_reuse_dir() which is needed by all init
  functionality regardless of the backend.
@essiene essiene enabled auto-merge (rebase) February 3, 2024 14:13
@essiene essiene merged commit 8423c63 into main Feb 3, 2024
15 checks passed
@essiene essiene deleted the essiene/2747/1 branch February 3, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

@martinvonz martinvonz Awaiting requested review from martinvonz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@essiene @yuja