Refactor out git_init() #2807
Merged
Refactor out git_init() #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essiene
force-pushed
the
essiene/2747/refactor
branch
4 times, most recently
from
bc2eb71 to
2848341
Compare
yuja
reviewed
Jan 11, 2024
There was a problem hiding this comment.
- Add Workspace::create_workspace_root() which is needed by all init functionality regardless of the backend.
- Move canonicalization of the external git repo path into the Workspace::init_git_external(). This keeps necessary code together.
- Create a git_init() function in cli/src/commands/init.rs where all git related work is done. This function will be moved to cli/src/commands/git.rs in a subsequent PR.
- Add a new variant of WorkspaceInitError for reporting path not found errors. The user error string is written to pass existing tests.
If you have some of these as separate commits, can you send them without squashing? It's a bit hard to review code move including changes.
This was referenced Jan 15, 2024
essiene
force-pushed
the
essiene/2747/refactor
branch
from
2848341 to
ac52647
Compare
I've split these up now. Thanks for prompting. I've stacked the changes up nicely, which means that this PR now has a different base CL than |
essiene
changed the title
essiene
force-pushed
the
essiene/2747/2
branch
from
3a6db44 to
938bf01
Compare
essiene
force-pushed
the
essiene/2747/refactor
branch
from
ac52647 to
1325bd0
Compare
yuja
reviewed
Jan 16, 2024
essiene
force-pushed
the
essiene/2747/1
branch
2 times, most recently
from
47ae233 to
b284701
Compare
essiene
force-pushed
the
essiene/2747/refactor
branch
2 times, most recently
from
4a52f92 to
8b9db06
Compare
essiene
force-pushed
the
essiene/2747/1
branch
from
b284701 to
189978b
Compare
essiene
force-pushed
the
essiene/2747/refactor
branch
from
8b9db06 to
0995d64
Compare
essiene
force-pushed
the
essiene/2747/refactor
branch
2 times, most recently
from
5041ec2 to
a85fcde
Compare
* Create a git_init() function in cli/src/commands/init.rs where all git related work is done. This function will be moved to cli/src/commands/git.rs in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable: