Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: add 'static version of evaluate_revset(), forbid unsafe #2706

Merged
merged 5 commits into from
Dec 15, 2023
Merged

revset: add 'static version of evaluate_revset(), forbid unsafe #2706

merged 5 commits into from
Dec 15, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Dec 15, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 5 commits December 15, 2023 15:00
@yuja
index: extract as_composite() to trait method
b95c510 
The revset engine will accept abstract AsCompositeIndex type, and the
evaluated revset can be 'static if the index is behind Arc<T>.
@yuja
revset: abstract evaluated RevsetImpl over owned/borrowed index types
163b81c
@yuja
index: add 'static version of evaluate_revset() to ReadonlyIndex
4205a1c 
We'll probably need a better abstraction, but a separate method is good
enough to remove unsafe code from ReadonlyRepo.

I'm not sure if this is feasible for the other backends, but I guess there
would be less lifetimed variables than DefaultReadonlyIndex.
@yuja
repo: remove unsafe lifetime hack from change_id_index()
a11711a
@yuja
lib: forbid unsafe_code at all
824fcb3
@yuja yuja mentioned this pull request Dec 15, 2023
Merged
4 tasks
martinvonz
martinvonz approved these changes Dec 15, 2023
View reviewed changes
lib/src/index.rs Show resolved Hide resolved
lib/src/lib.rs Show resolved Hide resolved
@yuja yuja merged commit af6047a into jj-vcs:main Dec 15, 2023
15 checks passed
@yuja yuja deleted the push-wqlmozwzoomm branch December 15, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz