revset: remove 'index lifetime from InternalRevset #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that InternalRevset will store a 'static boilerplate function that borrows an 'index passed by function argument. This way, we can abstract the index type over Arc<T> and &T without introducing too much generics.
This adds overhead to re-look up IndexEntry, but I don't think that would have significant impact on performance.
The returned iterator is boxed by caller due to the limitation of the type system. There's a workaround, but it's super ugly. https://users.rust-lang.org/t/hrtb-on-multiple-generics/34255/3
Also renamed the boxed version to discriminate it from the cast helper.
martinvonz
reviewed
Dec 15, 2023
|
The goal is to remove main...yuja:jj:push-ntksqqnrwqpy We can also rewrite RevWalk, etc. to hold |
Oh, that seems nice. Thanks for working on that. I've already reviewed this PR, so I'll go and approve it now. |
martinvonz
approved these changes
Dec 15, 2023
|
And the last bits to remove Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md