docs: try to clarify that we want contributors to squash fixup commits #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's happened a few times that contributors misunderstood the guidelines, so they're clearly not clear enough. Hopefully this clarifies.
PhilipMetzger
approved these changes
Sep 7, 2023
|
Ah, I already got a thumbs up from @sullyj3, so no need for formal approval. I'll merge this now. |
|
Yep, this definitely seems clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's happened a few times that contributors misunderstood the guidelines, so they're clearly not clear enough. Hopefully this clarifies.
Checklist
If applicable:
CHANGELOG.md