Skip to content

Commit

Permalink
docs: try to clarify that we want contributors to squash fixup commits
Browse files Browse the repository at this point in the history
It's happened a few times that contributors misunderstood the
guidelines, so they're clearly not clear enough. Hopefully this
clarifies.
  • Loading branch information
martinvonz committed Sep 7, 2023
1 parent 8660b39 commit 233b31f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ information on using pull requests.

Unlike many GitHub projects (but like many VCS projects), we care more about the
contents of commits than about the contents of PRs. We review each commit
separately, and we don't squash them when the PR is ready.
separately, and we don't squash-merge the PR (so please manually squash any
fixup commits before sending for review).

Each commit should ideally do one thing. For example, if you need to refactor a
function in order to add a new feature cleanly, put the refactoring in one
Expand Down

0 comments on commit 233b31f

Please sign in to comment.